Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log allowedHosts missing value checks and skip allowedHosts on resets #21935

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Jan 26, 2023

This PR closes #21921.

#21676 introduced a check to ensure that the interpolated values required for allowedHosts from connector configs was present, and threw an error if missing. This caused on call errors (https://github.com/airbytehq/oncall/issues/1373). #21923 removes the throw, and this PR figured out what went wrong.

Reset Connections
A Reset connection is a bit of a hack. The source the connection normally uses is replaced with a "mock" source that produces no records. This source also doesn't get the config which is normally associated with the source. This is why, for reset connections, https://github.com/airbytehq/oncall/issues/1373 occurred.

Logging

For now, we can log if there's an error interpolating the values needed for allowedHosts, rather than throwing an error.

airbyte-worker | 2023-01-26 19:42:58 ERROR i.a.w.u.ConfigReplacer(getAllowedHosts):60 - The allowedHost value, '${host}', is expecting an interpolation value from the connector's configuration, but none is present

@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/worker Related to worker labels Jan 26, 2023
@evantahler evantahler marked this pull request as ready for review January 26, 2023 19:50
@evantahler evantahler temporarily deployed to more-secrets January 26, 2023 19:51 — with GitHub Actions Inactive
@evantahler evantahler temporarily deployed to more-secrets January 26, 2023 19:51 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

File Coverage [39.95%]
ConfigReplacer.java 92.39% 🍏
DockerProcessFactory.java 72.69% 🍏
GenerateInputActivityImpl.java 1.2%
KubeProcessFactory.java 0%
Total Project Coverage 23.99%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Learn what went wrong with allowedHosts check on prod
3 participants