Log allowedHosts
missing value checks and skip allowedHosts
on resets
#21935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #21921.
#21676 introduced a check to ensure that the interpolated values required for allowedHosts from connector configs was present, and threw an error if missing. This caused on call errors (https://github.com/airbytehq/oncall/issues/1373). #21923 removes the
throw
, and this PR figured out what went wrong.Reset Connections
A Reset connection is a bit of a hack. The source the connection normally uses is replaced with a "mock" source that produces no records. This source also doesn't get the config which is normally associated with the source. This is why, for reset connections, https://github.com/airbytehq/oncall/issues/1373 occurred.
Logging
For now, we can log if there's an error interpolating the values needed for allowedHosts, rather than throwing an error.