-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off default httpavailabilitystrategy for source-google-analytics-v4 (GA) #22006
Conversation
/test connector=connectors/source-google-analytics-v4
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your change is 👍, but I don't really know how to interpret the SAT failure:
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
SAT is successful - those are for the skipped checks. You'll see it on other successes and failures (e.g. here) The new QA checks are failing because it can't tell if the changelog has been updated. Pretty sure this is due to the weird naming on the google analytics sources vs their documentation. This should be fixed (change the docs names?) but I'm not sure all the ramifications of where those docs files are used and would probably do that separately |
docs/integrations/sources/google-analytics-universal-analytics.md
Outdated
Show resolved
Hide resolved
/publish connector=connectors/source-google-analytics-v4
if you have connectors that successfully published but failed definition generation, follow step 4 here |
Airbyte Code Coverage
|
See #21888 for description