Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off default httpavailabilitystrategy for source-google-analytics-v4 (GA) #22006

Merged
merged 5 commits into from
Jan 31, 2023

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Jan 27, 2023

See #21888 for description

@octavia-squidington-iv octavia-squidington-iv added connectors/source/google-analytics-v4 area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jan 27, 2023
@erohmensing erohmensing changed the title Turn off default for source-google-analytics-v4 (GA) Turn off default httpavailabilitystrategy for source-google-analytics-v4 (GA) Jan 27, 2023
@erohmensing
Copy link
Contributor Author

erohmensing commented Jan 27, 2023

/test connector=connectors/source-google-analytics-v4

🕑 connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/4028383627
❌ connectors/source-google-analytics-v4 https://github.com/airbytehq/airbyte/actions/runs/4028383627
🐛

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.
================== 30 passed, 2 skipped in 236.27s (0:03:56) ===================

@erohmensing erohmensing requested a review from a team January 27, 2023 21:47
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your change is 👍, but I don't really know how to interpret the SAT failure:

SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:377: The previous and actual discovered catalogs are identical.

@erohmensing
Copy link
Contributor Author

SAT is successful - those are for the skipped checks. You'll see it on other successes and failures (e.g. here)

The new QA checks are failing because it can't tell if the changelog has been updated. Pretty sure this is due to the weird naming on the google analytics sources vs their documentation. This should be fixed (change the docs names?) but I'm not sure all the ramifications of where those docs files are used and would probably do that separately

@erohmensing
Copy link
Contributor Author

erohmensing commented Jan 30, 2023

/publish connector=connectors/source-google-analytics-v4

🕑 Publishing the following connectors:
connectors/source-google-analytics-v4
https://github.com/airbytehq/airbyte/actions/runs/4048614771


Connector Did it publish? Were definitions generated?
connectors/source-google-analytics-v4

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 30, 2023 22:37 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 30, 2023 22:37 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.47%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/google-analytics-v4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants