-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bechurch/21720 versioned connector build status #22029
Bechurch/21720 versioned connector build status #22029
Conversation
Airbyte Code Coverage
|
5ffecaf
to
3e1547f
Compare
Github hack - if you use the phrase "closes #ticket" it will link up the PR and Issue, and close the issue when the PR is merged.
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Ben!
@@ -42,5 +42,23 @@ full_path_to_gradle_path() { | |||
python -c "print(':airbyte-' + ':'.join(p for p in '${path}'.split('airbyte-')[-1].replace('/', ':').split(':') if p))" | |||
} | |||
|
|||
get_connector_path_from_name() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
/test connector=connectors/source-faker
Build FailedTest summary info:
|
/test connector=connectors/source-pokeapi
Build PassedTest summary info:
|
What
Closes #21720
This issue needs the connector version alongside the build status for each connector.
This is so that we can proactively mark connectors as "Ready for cloud"
How
This accomplishes it with the following changes
$CONNECTOR/$VERSION
What else
We've made an additional effort in this PR to ensure that
tests/history/connectors
nottests/history
. (Currently they are being recorded to both)tests/history/connectors
Recommended reading order
🚨 User Impact 🚨
No breaking change if successful.
However, there is a risk here that a part of the system is made stale. This is because we've made an effort to standardize the build report path, which means that theres a chance we missed a system that still references the old path.
Though thats low risk low impact
Pre-merge Checklist
Expand the relevant checklist and delete the others.
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
./test connector=connectors/<name>
command is passingPost merge
Tests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.