🪟 🧹 Optimizedestination over fetching - pass destination through react-router outlet context
#22068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dizel852
requested review from
edmundito and
matter-q
and removed request for
YatsukBogdan1
edmundito
reviewed
Jan 30, 2023
airbyte-webapp/src/pages/destination/DestinationOverviewPage.tsx
Outdated
Show resolved
Hide resolved
edmundito
approved these changes
Jan 31, 2023
dizel852
deleted the
vlad/21667-optimize-destination-loading-outlet-context
branch
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves #21667
How
Fetch the
destinationobject once and pass it through the react-router<Outlet />context