HOTFIX: Add version prefix to build status files #22126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
approved these changes
Jan 31, 2023
Comment on lines
71
to
74
| LAST_TEN_FILES=$(aws s3api list-objects-v2 --bucket "$BUCKET" \ | ||
| --query "reverse(sort_by(Contents[?contains(Key, \`tests/history/$CONNECTOR\`)], &LastModified))[:10].Key" \ | ||
| --prefix "tests/history/$CONNECTOR" \ | ||
| --query "reverse(sort_by(Contents[?!contains(Key, \`$VERSION_PREFIX\`)], &Key))[:10].Key" \ | ||
| --output=text) |
There was a problem hiding this comment.
This query is done by the S3 API, yes? That means we don't actually need to download the ever-growing list of files and do the sort locally?
There was a problem hiding this comment.
That also why this took a bit longer as I wanted to make s3 responsilbe for the final "take 10". Just so this wouldnt get slower and slower as more logs pile up
Airbyte Code Coverage
|
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When migrating previous build status reports from
test/history/${CONNECTOR}totest/history/connectors/${CONNECTOR}the information forlast_modified_atwas set to today.This caused our login for the reports to be invalid
How
This solves it by
Roadblocks Encountered
A few were encountered here.
Post merge
s3 copy script