🪟 🔧 Add isCorporate to Airbyte.UI.User.Create #22137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use this event to track conversions across paid channels such as
Google Ads.
Since we are only interested in corporate signups, we only want to track
a successful conversion in those cases.
Previously, we only added the `isCorporate` flag on `.identify()` but we
need this info also in `.track('Airbyte.UI.User.Create')`
Context: https://docs.google.com/document/d/13JbXLgAEVQmMoCBOPdDzAKpzwvqGclMcGSdA3bQ5KYQ/edit?disco=AAAAofb14Pg
letiescanciano
force-pushed
the
leti/add-is-corporate-in-user-create
branch
from
0565eee
to
c243ee6
Compare
timroes
reviewed
Jan 31, 2023
airbyte-webapp/src/packages/cloud/services/auth/AuthService.tsx
Outdated
Show resolved
Hide resolved
timroes
approved these changes
Jan 31, 2023
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this event to track conversions across paid channels such as Google Ads.
Since we are only interested in corporate signups, we only want to track a successful conversion in those cases.
Previously, we only added the
isCorporateflag on.identify()but we need this info also in.track('Airbyte.UI.User.Create')Context: https://docs.google.com/document/d/13JbXLgAEVQmMoCBOPdDzAKpzwvqGclMcGSdA3bQ5KYQ/edit?disco=AAAAofb14Pg