Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a repository method that determines if a connection has an alpha or beta connector #22190

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

pmossman
Copy link
Contributor

@pmossman pmossman commented Feb 1, 2023

What

In order to determine whether a particular connection should be allowed to continue running even in a delinquent workspace with negative credits, we need a simple way to check if a connection has an alpha or beta connector. This check should be performant so that we can perform it in API call validations and in our billing cron.

How

Write a new configRepository method that joins the connection with actor -> actor_definition and uses the definition's release stage to return a boolean.

Cloud will call this new method when validating free connector usage in the API and cron.

@pmossman pmossman requested a review from a team as a code owner February 1, 2023 01:40
@pmossman pmossman temporarily deployed to more-secrets February 1, 2023 01:42 — with GitHub Actions Inactive
@pmossman pmossman temporarily deployed to more-secrets February 1, 2023 01:42 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Airbyte Code Coverage

File Coverage [82.13%] 🍏
ConfigRepository.java 82.13% 🍏
Total Project Coverage 24.53%

Copy link
Contributor

@mfsiega-airbyte mfsiega-airbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants