Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🔧 Prevent usage of dangerouslySetInnerHTML #22201

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

timroes
Copy link
Collaborator

@timroes timroes commented Feb 1, 2023

What

Adds the react/no-danger linting rule to prevent any usage of dangerouslySetInnerHTML. The very very few places it makes sense to use this, can ignore the rule in line with a description of why we know the passed in HTML is safe.

@octavia-squidington-iv octavia-squidington-iv added the area/frontend Related to the Airbyte webapp label Feb 1, 2023
Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@dizel852 dizel852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants