Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: refresh actor configuration and state between sync attempts" #22211

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Revert "fix: refresh actor configuration and state between sync attempts" #22211

merged 1 commit into from
Feb 1, 2023

Conversation

pedroslopez
Copy link
Contributor

@pedroslopez pedroslopez commented Feb 1, 2023 •
edited
Loading

@pedroslopez pedroslopez requested a review from a team as a code owner February 1, 2023 15:37
@octavia-squidington-iv octavia-squidington-iv added area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server area/worker Related to worker labels Feb 1, 2023
jdpgrailsdev
jdpgrailsdev approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pedroslopez pedroslopez enabled auto-merge (squash) February 1, 2023 15:38
@pedroslopez pedroslopez temporarily deployed to more-secrets February 1, 2023 15:39 — with GitHub Actions Inactive
@pedroslopez pedroslopez temporarily deployed to more-secrets February 1, 2023 15:39 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Airbyte Code Coverage

File Coverage [76.45%] 🍏
DefaultJobCreator.java 100% 🍏
DefaultJobPersistence.java 95.54% 🍏
JobTracker.java 94.6% 🍏
Attempt.java 85.25% 🍏
Job.java 84.22% 🍏
TemporalWorkerRunFactory.java 83.17% 🍏
JobPersistence.java 80% 🍏
TemporalClient.java 61.44% 🍏
GenerateInputActivityImpl.java 1.19% ❌
ApiClientBeanFactory.java 0% ❌
ProtocolConverters.java 0% ❌
StateConverter.java 0% ❌
AttemptApiController.java 0% ❌
ApplicationBeanFactory.java 0% ❌
Total Project Coverage 24.51% ❌

@pedroslopez pedroslopez temporarily deployed to more-secrets February 1, 2023 16:49 — with GitHub Actions Inactive
@pedroslopez pedroslopez temporarily deployed to more-secrets February 1, 2023 16:49 — with GitHub Actions Inactive
@pedroslopez pedroslopez merged commit 7978862 into master Feb 1, 2023
@pedroslopez pedroslopez deleted the revert-21629-pedroslopez/attempt-sync-config branch February 1, 2023 17:15
pedroslopez added a commit that referenced this pull request Feb 2, 2023
@pedroslopez
Revert "Revert "fix: refresh actor configuration and state between sy…
690ce30 
…nc attempts (#21629)" (#22211)"

This reverts commit 7978862.
@pedroslopez pedroslopez mentioned this pull request Feb 2, 2023
Merged
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 2, 2023
Closed
@github-actions github-actions bot mentioned this pull request Feb 7, 2023
Closed
pedroslopez added a commit that referenced this pull request Feb 7, 2023
@pedroslopez
Revert "Revert "fix: refresh actor configuration and state between sy…
44d747d 
…nc attempts"" (#22281)

* Revert "Revert "fix: refresh actor configuration and state between sync attempts (#21629)" (#22211)"

This reverts commit 7978862.

* fmt
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 8, 2023
Closed
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
@pedroslopez @danidelvalle-frontiers
Revert "Revert "fix: refresh actor configuration and state between sy…
5472528 
…nc attempts"" (airbytehq#22281)

* Revert "Revert "fix: refresh actor configuration and state between sync attempts (airbytehq#21629)" (airbytehq#22211)"

This reverts commit 7978862.

* fmt
This was referenced Feb 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

Assignees
No one assigned
Labels
area/api Related to the api area/documentation Improvements or additions to documentation area/platform issues related to the platform area/server area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedroslopez @jdpgrailsdev @octavia-squidington-iv