Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connector Builder] Set placeholder documentation_url for builder-generated spec #22340

Merged
merged 2 commits into from
Feb 6, 2023
Merged

[Connector Builder] Set placeholder documentation_url for builder-generated spec #22340

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3281b03
set placeholder documentation_url for builder-generated spec
lmossman Feb 2, 2023
26194be
Switch to example.org
lmossman Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-webapp/src/components/connectorBuilder/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ export const convertToManifest = (values: BuilderFormValues): ConnectorManifest

const spec: Spec = {
connection_specification: specSchema,
documentation_url: "",
documentation_url: "https://docsurl.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: What about using https://example.org/ for this? Its official purpose is to be used as an example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that suggestion, will update

type: "Spec",
};

Expand Down