Use shallow clone in the getting started example #22407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AirByte repository got pretty big. This results in rather long clone time for getting started, which is mostly redundant. By using the `--depth` option the clone becomes much faster. I find it to be a better way to get started with the project quickly.
|
|
juweins
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Hey @kfirgollan ! Thank you for this addition to increase user experience! Sometimes, there is only little change needed for improvement!
Welcome to the Contributor of Airbyte! 🎉
Regarding this PR: LGTM!
Does it make sense to add a note clarifying why we use depth 1? Or does that speak for itself (From a new/juniors' perspective)
@sajarin it's your turn
marcosmarxm
approved these changes
Feb 7, 2023
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
The AirByte repository got pretty big. This results in rather long clone time for getting started, which is mostly redundant. By using the `--depth` option the clone becomes much faster. I find it to be a better way to get started with the project quickly.
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The AirByte repository got pretty big. This results in rather long clone time for getting started, which is mostly redundant. By using the
--depthoption the clone becomes much faster.How
Minor update in the main README file.
Add
--depth 1for the clone example.🚨 User Impact 🚨
In case of users without experience with git changing branches can be harder after clone.