-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪟 🚦 Add base E2E test for new stream table (part 1) #22412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
dizel852
changed the title
🪟 🚦 Add base E2E test for new stream table
🪟 🚦 Add base E2E test for new stream table (part 1)
Feb 7, 2023
edmundito
reviewed
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just had a couple of nits and a question.
airbyte-webapp-e2e-tests/cypress/integration/streamTable.spec.ts
Outdated
Show resolved
Hide resolved
airbyte-webapp-e2e-tests/cypress/integration/streamTable.spec.ts
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/components/connection/ConnectionOnboarding/ConnectionOnboarding.tsx
Outdated
Show resolved
Hide resolved
edmundito
approved these changes
Feb 8, 2023
danidelvalle
pushed a commit
to danidelvalle/airbyte
that referenced
this pull request
Feb 9, 2023
* extend api types * add test ids * extend submit button click * add more interceptors * add clickNewConnectionButton function and selector * add newConnection file with selectors and functions * add streamTable spec file with base flow * add interceptor for getting source definition request * add populate db steps * remove obsolete data-id="new-connection" * rename file * move file to connection folder
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Related to #18267
How
The test skips user flow: create source and destination connectors via UI.
We create them via API request and then start creating a new connection flow from choosing the existing ones.
Areas covered in the base test: