-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Filter out system views out of system namespaces #22427
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es' into feat/exclude-system-views-postgres
octavia-squidington-iii
added
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/bigquery
connectors/source/postgres
connectors/source/mongodb-v2
connectors/source/jdbc
connectors/source/relational-db
connectors/source/postgres-strict-encrypt
labels
Feb 6, 2023
sergio-ropero
temporarily deployed
to
more-secrets
February 6, 2023 18:35
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 6, 2023 18:35
— with
GitHub Actions
Inactive
Affected Connector ReportNOTE
|
Connector | Version | Changelog | Publish |
---|---|---|---|
source-alloydb |
1.0.44 |
✅ | ✅ |
source-alloydb-strict-encrypt |
1.0.44 |
🔵 (ignored) |
🔵 (ignored) |
source-bigquery |
0.2.3 |
✅ | ✅ |
source-clickhouse |
0.1.15 |
✅ | ✅ |
source-clickhouse-strict-encrypt |
0.1.15 |
🔵 (ignored) |
🔵 (ignored) |
source-cockroachdb |
0.1.19 |
✅ | ✅ |
source-cockroachdb-strict-encrypt |
0.1.19 |
🔵 (ignored) |
🔵 (ignored) |
source-db2 |
0.1.17 |
✅ | ✅ |
source-db2-strict-encrypt |
0.1.17 |
🔵 (ignored) |
🔵 (ignored) |
source-dynamodb |
0.1.0 |
✅ | ✅ |
source-jdbc |
0.3.5 |
🔵 (ignored) |
🔵 (ignored) |
source-mongodb-strict-encrypt |
0.1.19 |
🔵 (ignored) |
🔵 (ignored) |
source-mongodb-v2 |
0.1.19 |
✅ | ✅ |
source-mssql |
0.4.28 |
✅ | ✅ |
source-mssql-strict-encrypt |
0.4.28 |
🔵 (ignored) |
🔵 (ignored) |
source-mysql |
1.0.21 |
✅ | ✅ |
source-mysql-strict-encrypt |
1.0.21 |
🔵 (ignored) |
🔵 (ignored) |
source-oracle |
0.3.22 |
✅ | ✅ |
source-oracle-strict-encrypt |
0.3.22 |
🔵 (ignored) |
🔵 (ignored) |
source-postgres |
1.0.44 |
✅ | ✅ |
source-postgres-strict-encrypt |
1.0.44 |
🔵 (ignored) |
🔵 (ignored) |
source-redshift |
0.3.16 |
✅ | ✅ |
source-scaffold-java-jdbc |
0.1.0 |
🔵 (ignored) |
🔵 (ignored) |
source-snowflake |
0.1.29 |
✅ | ✅ |
source-tidb |
0.2.2 |
✅ | ✅ |
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Destinations (0)
Connector | Version | Changelog | Publish |
---|
- See "Actionable Items" below for how to resolve warnings and errors.
✅ Other Modules (0)
Actionable Items
(click to expand)
Category | Status | Actionable Item |
---|---|---|
Version | ❌ mismatch |
The version of the connector is different from its normal variant. Please bump the version of the connector. |
⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
|
Changelog | ⚠ doc not found |
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug. |
❌ changelog missing |
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog. | |
Publish | ⚠ not in seed |
The connector is not in the seed file (e.g. source_definitions.yaml ), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug. |
❌ diff seed version |
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version. |
sergio-ropero
temporarily deployed
to
more-secrets
February 6, 2023 18:38
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 6, 2023 18:38
— with
GitHub Actions
Inactive
Airbyte Code Coverage
|
sergio-ropero
temporarily deployed
to
more-secrets
February 6, 2023 18:55
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 6, 2023 18:55
— with
GitHub Actions
Inactive
airbyteio
temporarily deployed
to
more-secrets
February 8, 2023 19:00
— with
GitHub Actions
Inactive
airbyteio
temporarily deployed
to
more-secrets
February 8, 2023 19:00
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 8, 2023 19:20
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 8, 2023 19:20
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 8, 2023 21:47
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 8, 2023 21:47
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 9, 2023 01:12
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 9, 2023 01:12
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 9, 2023 17:09
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 9, 2023 17:09
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 9, 2023 20:57
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 9, 2023 20:57
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 9, 2023 21:48
— with
GitHub Actions
Inactive
sergio-ropero
temporarily deployed
to
more-secrets
February 9, 2023 21:48
— with
GitHub Actions
Inactive
marcosmarxm
pushed a commit
that referenced
this pull request
Feb 9, 2023
* This changes allows to filter out system views created out of system namespaces * Add extra view * Fix issue * Bump Postgres source version * bump version * Bump alloydb * Bump versioning * auto-bump connector version * Set default implementation and remove from unneeded places --------- Co-authored-by: Octavia Squidington III <[email protected]>
sh4sh
pushed a commit
that referenced
this pull request
Feb 10, 2023
* This changes allows to filter out system views created out of system namespaces * Add extra view * Fix issue * Bump Postgres source version * bump version * Bump alloydb * Bump versioning * auto-bump connector version * Set default implementation and remove from unneeded places --------- Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/alloydb
connectors/source/alloydb-strict-encrypt
connectors/source/bigquery
connectors/source/jdbc
connectors/source/mongodb-v2
connectors/source/postgres
connectors/source/postgres-strict-encrypt
connectors/source/relational-db
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #22221 after rollbacked due to error in the deploy process.
This changes allows to filter out system views created out of system namespaces.
Issue: #1323
As the only impacted DB is Postgres, we will bump only that image.
TEST
Current version (1.0.42)
PR version (dev)