Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filter out system views out of system namespaces #22427

Merged
merged 25 commits into from
Feb 9, 2023

Conversation

sergio-ropero
Copy link
Contributor

@sergio-ropero sergio-ropero commented Feb 6, 2023

Reopening #22221 after rollbacked due to error in the deploy process.

This changes allows to filter out system views created out of system namespaces.
Issue: #1323

As the only impacted DB is Postgres, we will bump only that image.

TEST

Current version (1.0.42)

Screenshot 2023-02-02 at 15 03 37

PR version (dev)

Screenshot 2023-02-02 at 15 02 48

@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 6, 2023 18:35 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 6, 2023 18:35 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (25)

Connector Version Changelog Publish
source-alloydb 1.0.44
source-alloydb-strict-encrypt 1.0.44 🔵
(ignored)
🔵
(ignored)
source-bigquery 0.2.3
source-clickhouse 0.1.15
source-clickhouse-strict-encrypt 0.1.15 🔵
(ignored)
🔵
(ignored)
source-cockroachdb 0.1.19
source-cockroachdb-strict-encrypt 0.1.19 🔵
(ignored)
🔵
(ignored)
source-db2 0.1.17
source-db2-strict-encrypt 0.1.17 🔵
(ignored)
🔵
(ignored)
source-dynamodb 0.1.0
source-jdbc 0.3.5 🔵
(ignored)
🔵
(ignored)
source-mongodb-strict-encrypt 0.1.19 🔵
(ignored)
🔵
(ignored)
source-mongodb-v2 0.1.19
source-mssql 0.4.28
source-mssql-strict-encrypt 0.4.28 🔵
(ignored)
🔵
(ignored)
source-mysql 1.0.21
source-mysql-strict-encrypt 1.0.21 🔵
(ignored)
🔵
(ignored)
source-oracle 0.3.22
source-oracle-strict-encrypt 0.3.22 🔵
(ignored)
🔵
(ignored)
source-postgres 1.0.44
source-postgres-strict-encrypt 1.0.44 🔵
(ignored)
🔵
(ignored)
source-redshift 0.3.16
source-scaffold-java-jdbc 0.1.0 🔵
(ignored)
🔵
(ignored)
source-snowflake 0.1.29
source-tidb 0.2.2
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 6, 2023 18:38 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 6, 2023 18:38 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero marked this pull request as ready for review February 6, 2023 18:40
@sergio-ropero sergio-ropero requested a review from a team as a code owner February 6, 2023 18:40
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.67%

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Platform Test Results

   244 files  ±0     244 suites  ±0   28m 23s ⏱️ + 2m 53s
1 666 tests ±0  1 655 ✔️ ±0  11 💤 ±0  0 ±0 
1 685 runs  ±0  1 674 ✔️ ±0  11 💤 ±0  0 ±0 

Results for commit 3f569b0. ± Comparison against base commit 015174a.

♻️ This comment has been updated with latest results.

@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 6, 2023 18:55 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 6, 2023 18:55 — with GitHub Actions Inactive
@airbyteio airbyteio temporarily deployed to more-secrets February 8, 2023 19:00 — with GitHub Actions Inactive
@airbyteio airbyteio temporarily deployed to more-secrets February 8, 2023 19:00 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero enabled auto-merge (squash) February 8, 2023 19:17
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 8, 2023 19:20 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 8, 2023 19:20 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 8, 2023 21:47 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 8, 2023 21:47 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 9, 2023 01:12 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 9, 2023 01:12 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 9, 2023 17:09 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 9, 2023 17:09 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 9, 2023 20:57 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 9, 2023 20:57 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 9, 2023 21:48 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero temporarily deployed to more-secrets February 9, 2023 21:48 — with GitHub Actions Inactive
@sergio-ropero sergio-ropero merged commit 1807c8f into master Feb 9, 2023
@sergio-ropero sergio-ropero deleted the feat/exclude-system-views-postgres branch February 9, 2023 22:20
marcosmarxm pushed a commit that referenced this pull request Feb 9, 2023
* This changes allows to filter out system views created out of system namespaces

* Add extra view

* Fix issue

* Bump Postgres source version

* bump version

* Bump alloydb

* Bump versioning

* auto-bump connector version

* Set default implementation and remove from unneeded places

---------

Co-authored-by: Octavia Squidington III <[email protected]>
sh4sh pushed a commit that referenced this pull request Feb 10, 2023
* This changes allows to filter out system views created out of system namespaces

* Add extra view

* Fix issue

* Bump Postgres source version

* bump version

* Bump alloydb

* Bump versioning

* auto-bump connector version

* Set default implementation and remove from unneeded places

---------

Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants