Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bmoric/right error for refresh #22471

Merged
merged 6 commits into from
Feb 7, 2023
Merged

Bmoric/right error for refresh #22471

merged 6 commits into from
Feb 7, 2023

Conversation

benmoriceau
Copy link
Contributor

@benmoriceau benmoriceau commented Feb 7, 2023 •
edited
Loading

What

Set a specific error if the refresh schema activity fails.

This PR set a meaningful error message, in order to avoid having an hard to understand root cause in case of a timeout error.

File Order

  • SyncWorkflowImpl (and test) => Catch all errors and return the right type.
  • SyncOutputProvider => Create the syncoutput with an error.
  • config.yml/failureReason.yml => add a new failure type specific to the refersh_schema. This might need to be in the failure origin instead. Happy to revisit it.

@octavia-squidington-iii octavia-squidington-iii added area/api Related to the api area/platform issues related to the platform area/worker Related to worker labels Feb 7, 2023
@benmoriceau benmoriceau temporarily deployed to more-secrets February 7, 2023 09:15 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets February 7, 2023 09:15 — with GitHub Actions Inactive
jdpgrailsdev
jdpgrailsdev approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benmoriceau benmoriceau temporarily deployed to more-secrets February 7, 2023 19:03 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets February 7, 2023 19:03 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets February 7, 2023 20:53 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets February 7, 2023 20:53 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets February 7, 2023 21:26 — with GitHub Actions Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets February 7, 2023 21:26 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Airbyte Code Coverage

File Coverage [89.79%] 🍏
SyncOutputProvider.java 95.38% 🍏
SyncWorkflowImpl.java 89.47% 🍏
SyncCheckConnectionFailure.java 87.79% 🍏
Total Project Coverage 24.57% ❌

@benmoriceau benmoriceau merged commit f9939c7 into master Feb 7, 2023
@benmoriceau benmoriceau deleted the bmoric/right-error-for-refresh branch February 7, 2023 22:16
@github-actions github-actions bot mentioned this pull request Feb 8, 2023
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 8, 2023
Closed
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
@benmoriceau @danidelvalle-frontiers
Bmoric/right error for refresh (airbytehq#22471)
b04321a 
* Get a better failure reason for the refresh schema error

* Use share empty stats

* Format

* Add missing import

* fix pmd
This was referenced Feb 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdpgrailsdev jdpgrailsdev jdpgrailsdev approved these changes

@colesnodgrass colesnodgrass Awaiting requested review from colesnodgrass

@gosusnp gosusnp Awaiting requested review from gosusnp

@malikdiarra malikdiarra Awaiting requested review from malikdiarra

@cgardens cgardens Awaiting requested review from cgardens

@alovew alovew Awaiting requested review from alovew

Assignees
No one assigned
Labels
area/api Related to the api area/platform issues related to the platform area/worker Related to worker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmoriceau @jdpgrailsdev @octavia-squidington-iii