Source Salesforce: handle too many properties #22597

davydov-d · 2023-02-08T19:43:34Z

What

https://github.com/airbytehq/oncall/issues/1403

How

Make multiple requests for a page, each for a limited set of properties, then merge results by a primary key.

davydov-d · 2023-02-08T19:45:05Z

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/4127818004
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/4127818004
Python tests coverage:

Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/utils.py               8      0   100%
source_salesforce/__init__.py            2      0   100%
source_salesforce/source.py             96      6    94%
source_salesforce/streams.py           370     32    91%
source_salesforce/api.py               155     14    91%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/rate_limiting.py      22      3    86%
--------------------------------------------------------
TOTAL                                  661     56    92%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/__init__.py            2      0   100%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/api.py               155     21    86%
source_salesforce/streams.py           370     78    79%
source_salesforce/rate_limiting.py      22      6    73%
source_salesforce/source.py             96     33    66%
source_salesforce/utils.py               8      7    12%
--------------------------------------------------------
TOTAL                                  661    146    78%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1696    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 36 passed, 2 skipped in 856.45s (0:14:16) ===================

airbyte-integrations/connectors/source-salesforce/source_salesforce/streams.py

…perties

davydov-d · 2023-02-09T09:26:34Z

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/4132801861
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/4132801861
🐛 https://gradle.com/s/wn66roq7aamdq

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/api_test.py::test_too_many_properties - AssertionError: ass...
	 �[31m============ �[31m�[1m1 failed�[0m, �[32m73 passed�[0m, �[33m241 warnings�[0m�[31m in 111.83s (0:01:51)�[0m�[31m ============�[0m

davydov-d · 2023-02-09T10:59:53Z

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/4133553184
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/4133553184
Python tests coverage:

Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/utils.py               8      0   100%
source_salesforce/__init__.py            2      0   100%
source_salesforce/source.py             96      6    94%
source_salesforce/streams.py           377     33    91%
source_salesforce/api.py               155     14    91%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/rate_limiting.py      22      3    86%
--------------------------------------------------------
TOTAL                                  668     57    91%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/__init__.py            2      0   100%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/api.py               155     21    86%
source_salesforce/streams.py           377     86    77%
source_salesforce/rate_limiting.py      22      6    73%
source_salesforce/source.py             96     33    66%
source_salesforce/utils.py               8      7    12%
--------------------------------------------------------
TOTAL                                  668    154    77%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1696    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 36 passed, 2 skipped in 650.83s (0:10:50) ===================

davydov-d · 2023-02-09T11:31:36Z

/publish connector=connectors/source-salesforce

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

davydov-d · 2023-02-09T11:42:30Z

/publish connector=connectors/source-salesforce

🕑 Publishing the following connectors:
connectors/source-salesforce
https://github.com/airbytehq/airbyte/actions/runs/4133884104

Connector	Did it publish?	Were definitions generated?
connectors/source-salesforce	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

github-actions · 2023-02-09T12:26:46Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.66%	❌

…perties

#1403 source Salesforce: handle too many properties

7bd4b45

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesforce labels Feb 8, 2023

#1403 source Salesforce: update changelog

8ffabc1

davydov-d requested review from alafanechere, lazebnyi, pedroslopez and roman-yermilov-gl February 8, 2023 19:45

grubberr reviewed Feb 9, 2023

View reviewed changes

airbyte-integrations/connectors/source-salesforce/source_salesforce/streams.py Outdated Show resolved Hide resolved

davydov-d added 2 commits February 9, 2023 11:15

Merge branch 'master' into ddavydov/#1403-source-salesforce-chunk-pro…

431ff45

…perties

#1403 source salesforce: log warning and skip inconsistent records

cf4eaf8

grubberr approved these changes Feb 9, 2023

View reviewed changes

#1403 source salesforce: review fixes

267d23c

auto-bump connector version

9289028

airbyteio temporarily deployed to more-secrets February 9, 2023 12:19 — with GitHub Actions Inactive

Merge branch 'master' into ddavydov/#1403-source-salesforce-chunk-pro…

8e8a899

…perties

davydov-d temporarily deployed to more-secrets February 9, 2023 12:59 — with GitHub Actions Inactive

lazebnyi approved these changes Feb 9, 2023

View reviewed changes

davydov-d merged commit b9d4f12 into master Feb 9, 2023

davydov-d deleted the ddavydov/#1403-source-salesforce-chunk-properties branch February 9, 2023 13:31

github-actions bot mentioned this pull request Feb 9, 2023

Bump helm chart version reference to 0.43.34 #22684

Closed

This was referenced Feb 10, 2023

Bump Airbyte version from 0.40.32 to 0.40.33 #22689

Closed

Bump Airbyte version from 0.40.32 to 0.40.33 #22839

Closed

vincentkoc mentioned this pull request Feb 12, 2023

Salesforce Stream "Account" cannot be processed by REST or BULK API #20703

Closed

davydov-d mentioned this pull request Mar 1, 2023

Source Salesforce: change the sequence of requests #23610

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Salesforce: handle too many properties #22597

Source Salesforce: handle too many properties #22597

davydov-d commented Feb 8, 2023

davydov-d commented Feb 8, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 9, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Feb 9, 2023

Source Salesforce: handle too many properties #22597

Source Salesforce: handle too many properties #22597

Conversation

davydov-d commented Feb 8, 2023

What

How

davydov-d commented Feb 8, 2023 • edited by github-actions bot Loading

Build Passed

davydov-d commented Feb 9, 2023 • edited by github-actions bot Loading

Build Failed

davydov-d commented Feb 9, 2023 • edited by github-actions bot Loading

Build Passed

davydov-d commented Feb 9, 2023 • edited by github-actions bot Loading

davydov-d commented Feb 9, 2023 • edited by github-actions bot Loading

github-actions bot commented Feb 9, 2023

Airbyte Code Coverage

davydov-d commented Feb 8, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 9, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 9, 2023 •

edited by github-actions bot

Loading