Source Salesforce: fix properties chunk length count #22896

davydov-d · 2023-02-13T11:39:26Z

What

#20703
this is a followup for oncall https://github.com/airbytehq/oncall/issues/1403

How

When counting the length of the URL we should take into account that properties and the separator will be URL-encoded

davydov-d · 2023-02-13T11:40:19Z

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/4163049630
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/4163049630
Python tests coverage:

Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/utils.py               8      0   100%
source_salesforce/__init__.py            2      0   100%
source_salesforce/source.py             96      6    94%
source_salesforce/streams.py           380     33    91%
source_salesforce/api.py               155     14    91%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/rate_limiting.py      22      3    86%
--------------------------------------------------------
TOTAL                                  671     57    92%
Name                                 Stmts   Miss  Cover
--------------------------------------------------------
source_salesforce/__init__.py            2      0   100%
source_salesforce/exceptions.py          8      1    88%
source_salesforce/api.py               155     21    86%
source_salesforce/streams.py           380     86    77%
source_salesforce/rate_limiting.py      22      6    73%
source_salesforce/source.py             96     33    66%
source_salesforce/utils.py               8      7    12%
--------------------------------------------------------
TOTAL                                  671    154    77%
	 Name                                                    Stmts   Miss  Cover   Missing
	 -------------------------------------------------------------------------------------
	 connector_acceptance_test/base.py                          12      4    67%   16-19
	 connector_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 connector_acceptance_test/conftest.py                     217    101    53%   37, 43-45, 50, 55, 78, 84, 90-92, 111, 116-118, 124-126, 132-133, 138-139, 144, 150, 159-168, 174-179, 194, 218, 249, 255, 263-271, 279-292, 300-313, 318-324, 331-342, 349-365
	 connector_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 connector_acceptance_test/tests/test_core.py              476    117    75%   53, 58, 97-108, 113-120, 124-125, 129-130, 380, 400, 438, 476-493, 506-517, 521-526, 532, 565-570, 608-615, 658-660, 663, 728-736, 748-751, 756, 812-813, 819, 822, 858-868, 881-906
	 connector_acceptance_test/tests/test_incremental.py       162     14    91%   58-65, 70-83, 252
	 connector_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 connector_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 connector_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 connector_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 connector_acceptance_test/utils/json_schema_helper.py     114     13    89%   31-32, 39, 42, 66-69, 97, 121, 203-205
	 -------------------------------------------------------------------------------------
	 TOTAL                                                    1711    347    80%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:98: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:507: The previous and actual discovered catalogs are identical.
================== 36 passed, 2 skipped in 581.56s (0:09:41) ===================

davydov-d · 2023-02-14T07:34:27Z

/publish connector=connectors/source-salesforce

🕑 Publishing the following connectors:
connectors/source-salesforce
https://github.com/airbytehq/airbyte/actions/runs/4171498353

Connector	Did it publish?	Were definitions generated?
connectors/source-salesforce	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…s-chunk-length

davydov-d · 2023-02-14T08:49:16Z

temporary unable to publish changes because of exceeding the rate limit

…s-chunk-length

github-actions · 2023-02-15T10:02:52Z

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage	24.66%	❌

…s-chunk-length

lazebnyi

CI tests looks good. We can move next to fix issue related to on-call issue. LGTM!

davydov-d · 2023-02-15T11:53:27Z

/publish connector=connectors/source-salesforce

davydov-d · 2023-02-15T11:56:48Z

/publish connector=connectors/source-salesforce

davydov-d · 2023-02-15T11:59:46Z

/publish connector=connectors/source-salesforce

davydov-d · 2023-02-15T12:19:18Z

/publish connector=connectors/source-salesforce

🕑 Publishing the following connectors:
connectors/source-salesforce
https://github.com/airbytehq/airbyte/actions/runs/4183783777

Connector	Did it publish?	Were definitions generated?
connectors/source-salesforce	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

…s-chunk-length

davydov-d · 2023-02-15T14:26:03Z

/approve-and-merge reason="A followup for oncall #1403"

octavia-approvington · 2023-02-15T14:26:42Z

This code is at peace with itself

#20703 Source Salesforce: fix properties chunk length count

82966a2

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesforce labels Feb 13, 2023

#20703 Source Salesforce: upd changelog

2bdcf63

davydov-d requested review from bazarnov, lazebnyi and maxi297 February 13, 2023 11:40

davydov-d mentioned this pull request Feb 13, 2023

Salesforce Stream "Account" cannot be processed by REST or BULK API #20703

Closed

bazarnov approved these changes Feb 13, 2023

View reviewed changes

lazebnyi approved these changes Feb 13, 2023

View reviewed changes

Merge branch 'master' into ddavydov/#20703-source-salesforce-fix-prop…

31782a3

…s-chunk-length

davydov-d self-assigned this Feb 14, 2023

davydov-d added the team/connectors-python label Feb 14, 2023

davydov-d added 2 commits February 15, 2023 11:52

Merge branch 'master' into ddavydov/#20703-source-salesforce-fix-prop…

3c2ec42

…s-chunk-length

#20703: source salesforce - add allowedHosts

4de082e

davydov-d temporarily deployed to more-secrets February 15, 2023 09:55 — with GitHub Actions Inactive

Merge branch 'master' into ddavydov/#20703-source-salesforce-fix-prop…

dec1e98

…s-chunk-length

davydov-d temporarily deployed to more-secrets February 15, 2023 10:56 — with GitHub Actions Inactive

lazebnyi approved these changes Feb 15, 2023

View reviewed changes

bazarnov approved these changes Feb 15, 2023

View reviewed changes

auto-bump connector version

d411e01

airbyteio temporarily deployed to more-secrets February 15, 2023 12:55 — with GitHub Actions Inactive

Merge branch 'master' into ddavydov/#20703-source-salesforce-fix-prop…

3b81e84

…s-chunk-length

davydov-d temporarily deployed to more-secrets February 15, 2023 13:43 — with GitHub Actions Inactive

octavia-approvington approved these changes Feb 15, 2023

View reviewed changes

octavia-approvington merged commit 53a5bd8 into master Feb 15, 2023

octavia-approvington deleted the ddavydov/#20703-source-salesforce-fix-props-chunk-length branch February 15, 2023 14:26

midavadim mentioned this pull request Mar 28, 2023

Source Salesforce: URI too long #14024

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Salesforce: fix properties chunk length count #22896

Source Salesforce: fix properties chunk length count #22896

davydov-d commented Feb 13, 2023 •

edited

Loading

davydov-d commented Feb 13, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 14, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 14, 2023

github-actions bot commented Feb 15, 2023

lazebnyi left a comment

davydov-d commented Feb 15, 2023

davydov-d commented Feb 15, 2023

davydov-d commented Feb 15, 2023

davydov-d commented Feb 15, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 15, 2023

octavia-approvington commented Feb 15, 2023

Source Salesforce: fix properties chunk length count #22896

Source Salesforce: fix properties chunk length count #22896

Conversation

davydov-d commented Feb 13, 2023 • edited Loading

What

How

davydov-d commented Feb 13, 2023 • edited by github-actions bot Loading

Build Passed

davydov-d commented Feb 14, 2023 • edited by github-actions bot Loading

davydov-d commented Feb 14, 2023

github-actions bot commented Feb 15, 2023

Airbyte Code Coverage

lazebnyi left a comment

Choose a reason for hiding this comment

davydov-d commented Feb 15, 2023

davydov-d commented Feb 15, 2023

davydov-d commented Feb 15, 2023

davydov-d commented Feb 15, 2023 • edited by github-actions bot Loading

davydov-d commented Feb 15, 2023

octavia-approvington commented Feb 15, 2023

davydov-d commented Feb 13, 2023 •

edited

Loading

davydov-d commented Feb 13, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 14, 2023 •

edited by github-actions bot

Loading

davydov-d commented Feb 15, 2023 •

edited by github-actions bot

Loading