Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only run review requirements on source connectors #23030

Merged
merged 1 commit into from
Feb 14, 2023
Merged

only run review requirements on source connectors #23030

merged 1 commit into from
Feb 14, 2023

Conversation

c-p-b
Copy link
Contributor

@c-p-b c-p-b commented Feb 14, 2023

What

I think this is misconfigured to run on EVERY pull request review event instead of just pull request review events on certain paths. Need to verify that is the case.

How

only fire on pull request review events for certain paths

only run review requirements on source connectors
515a35c 
I think this is misconfigured to run on EVERY pull request review event instead of just pull request review events on certain paths. Need to verify that is the case.
@c-p-b c-p-b temporarily deployed to more-secrets February 14, 2023 20:50 — with GitHub Actions Inactive
@c-p-b c-p-b temporarily deployed to more-secrets February 14, 2023 20:50 — with GitHub Actions Inactive
bnchrch
bnchrch approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should solve it.

@github-actions
Copy link
Contributor

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 24.66% ❌

@c-p-b
Copy link
Contributor Author

c-p-b commented Feb 14, 2023

/approve-and-merge reason="ci change only, no code change"

@octavia-approvington
Copy link
Contributor

Myomoto says it looks good
thats a niiice

@octavia-approvington octavia-approvington merged commit 15f851f into master Feb 14, 2023
@octavia-approvington octavia-approvington deleted the cpdeethree-patch-3 branch February 14, 2023 22:13
@pedroslopez pedroslopez mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnchrch bnchrch bnchrch approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-p-b @octavia-approvington @bnchrch