-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish connectors whose dockerfile versions were already updated #23318
Conversation
/test connector=connectors/source-recharge
Build FailedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/publish away!
I don't really know what to do if the tests fail though...
Ugh, yeah. Probably the same as last time - check if the failure is expected as of the latest #connector-health state and if so, publish without tests |
/test connector=connectors/source-slack
Build FailedTest summary info:
|
Both failures are the same as the ones currently on master: With no changes here, it's using the code already on master. Both test suites were passing when the code was merged, and tests have passed in nightly runs previously after they were merged, so I don't think the fact that they are failing now is related to those code changes. |
/publish connector=connectors/source-slack run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
/publish connector=connectors/source-recharge run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
I don't see any actors in the cloud DB that use destination-databend yet, so I think the deletion in the spec is safe - otherwise that would be a change we could probably have to enforce users who had selected a different protocol to use. |
What
The following connectors have dockerfile versions higher than on dockerhub because they weren't published, although their code was merged to master:
The following were published but the *_definitions.yml file wasn't generated automatically and wasn't manually updated accordingly:
How to fix
Publish the first 2 in this PR, updating the changelogs accordingly. Only changes should be changelog dates and commits made automatically via the publish workflow.
After the first 2 are published, manually update source_definitions.yml and destination_definitons.yml to reflect the correct latest versions for databend and tiktok marketing.