Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc add lsn extraction and comparison #2613

Merged
merged 4 commits into from
Mar 31, 2021
Merged

cdc add lsn extraction and comparison #2613

merged 4 commits into from
Mar 31, 2021

Conversation

cgardens
Copy link
Contributor

@cgardens cgardens commented Mar 25, 2021 •
edited
Loading

What

  • Adds helper to extract the current LSN from a postgres db with version > 9. (We can add support for version 9 if we want as well, but let's start here).
  • Adds helpers to allow comparing the magnitude of LSNS.
  • Still need to fix: it closes too eagerly because multiple records can have the same lsn. need to fix logic slightly so it includes all records with the same lsn.

Future work

  • Figure out how pulling LSN or equivalent can be ergonomic for all databases.
  • Use this in the CDC impl of postgres

@jrhizor we can merge this into master or directly into feature branch. Will do the right thing one approved.

@cgardens cgardens requested a review from jrhizor March 25, 2021 20:22
@cgardens cgardens changed the base branch from master to jrhizor/debezium March 25, 2021 23:32
@jrhizor
Copy link
Contributor

jrhizor commented Mar 25, 2021

pgoutput is only supported 10+ anyways

jrhizor
jrhizor approved these changes Mar 25, 2021
View reviewed changes
airbyte-db/src/main/java/io/airbyte/db/PostgresUtils.java
import java.sql.SQLException;
import java.util.List;

public class PostgresUtils {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments for each of these functions should be enough to understand what's going on without following the refs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

...rs/source-postgres/src/main/java/io/airbyte/integrations/source/postgres/PostgresSource.java Outdated
@@ -127,6 +138,19 @@ public JsonNode toJdbcConfig(JsonNode config) {
JdbcStateManager stateManager,
Instant emittedAt) {
if (isCdc(config)) {
final String targetLsn = getLsn(database);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should log this on retrieval here

sherifnada
sherifnada reviewed Mar 31, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started reviewing but I realized this may not be ready for review so I just left whatever comments I had. ping again if another review is needed

airbyte-db/src/main/java/io/airbyte/db/PostgresUtils.java Outdated
String logicalXLogStr = lsn.substring(0, slashIndex);
// parses as a long but then cast to int. this allows us to retain the full 32 bits of the integer
// as opposed to the reduced value of Integer.MAX_VALUE.
int logicalXlog = (int) Long.parseLong(logicalXLogStr, 16);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be Integer.parseUnsignedInt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no. Integer.parseUnsignedInt can't parse a value that is greater than max int in java. In this case it is possible we will be parsing something greater than java's max int.

...rs/source-postgres/src/main/java/io/airbyte/integrations/source/postgres/PostgresSource.java Outdated
@@ -127,6 +141,30 @@ public JsonNode toJdbcConfig(JsonNode config) {
JdbcStateManager stateManager,
Instant emittedAt) {
if (isCdc(config)) {
final String targetLsn = getLsn(database);
LOGGER.info("identified target lsn: " + targetLsn);
final Predicate<JsonNode> hasReachedLsnPredicate = (record) -> Optional.ofNullable(record.get("value"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the schema of the object being deserialized? is that mentioned anywhere?

@cgardens
add lsn extraction and comparison
929a042 
lsn extraction

wip

wip

it completes

it terminates
@cgardens
seems to work
04d4cc5
@cgardens cgardens merged commit 825e324 into jrhizor/debezium Mar 31, 2021
@cgardens cgardens deleted the cgardens/lsn_extraction branch March 31, 2021 23:53
@cgardens cgardens changed the title add lsn extraction and comparison cdc add lsn extraction and comparison Apr 2, 2021
@cgardens cgardens mentioned this pull request Apr 5, 2021
Closed
jrhizor added a commit that referenced this pull request Apr 9, 2021
@jrhizor @cgardens
postgres cdc (#2548)
2b19da8 
* spike

* more

* debezium wip

* use oneof for configuration

* iterator wrapping structure

* push current

* working loop

* move capability into source

* hack it into a sharable state

* debezium test runner (#2617)

* CDC Wait for Values (#2618)

* output actual AirbyteMessages for cdc (#2631)

* message conversion

* fmt

* add lsn extraction and comparison (#2613)

* postgres cdc catalog (#2673)

* update cdc catalog

* A

* table selection for cdc (#2690)

* table selection for cdc

* fix broken merge

* also test double quote in name

* Add state management to CDC (#2718)

* CDC: Fix Producer/Consumer State Machine (#2721)

* CDC Postgres Tests (#2777)

* fix postgres cdc image name and run check before reading data (#2785)

* minor postgres cdc fixes

* add test and fix check behavior

* fix

* improve comment

* remove unused props, remove todos, add some more sanity tests (#2791)

* cdc: add offset store tests (#2793)

* clean (#2798)

* postgres cdc docs (#2784)

* cdc docs

* Update docs/integrations/sources/postgres.md

Co-authored-by: Charles <[email protected]>

* address gcp

* learn too english

* add link

* add more disk space warnings

* add additional cdc use case

* add information on how to find postgresql.conf

* add how to find the file

Co-authored-by: Charles <[email protected]>

* various merge conflict fixes (#2799)

* cdc standard tests (#2813)

* require cdc users to create publications & update docs (#2818)

* postgres cdc race condition

* working? but different process

* add additional logging to help debug in the future

* everything done except working config

* remove unintended change

* Use oneOf in PG CDC spec (#2827)

* add oneOf configuration for postgres cdc  (#2831)

* add oneof configuration for cdc postgres

* fmt

Co-authored-by: Charles <[email protected]>

* fix test (#2834)

* fix test

* bump version

* add docs on creating replica identities (#2838)

* add docs on creating replica identities

* emphasize danger

* grammar

* bump pg version in source catalog

* generate seed files

Co-authored-by: cgardens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada left review comments

@jrhizor jrhizor jrhizor approved these changes

@ChristopheDuong ChristopheDuong Awaiting requested review from ChristopheDuong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgardens @jrhizor @sherifnada