airbyte-lib: Allow to skip slower tests #34901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Feb 12, 2024
|
Replaced by: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always let the tests run locally to validate things after a change. However, the tests currently take 1.5 minutes roughly - as half of this is spent with snowflake and postgres tests which usually are not relevant to core library changes (as all sql caches work the same), this PR is flagging some tests so it's easy to skip them via
poetry run pytest -m "not slow".We could also re-arrange our tests and put all the slow ones in one file or so, but this seems like a good strategy for the specific issue.
Without the slow tests, the whole suite takes 45 seconds instead, but gives mostly the same guarantees as there are extensive integration tests with duckdb.