Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle.yml: fix path filters #35554

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,25 +22,26 @@ on:
jobs:
changes:
runs-on: ubuntu-latest
outputs:
java: ${{ steps.changes.outputs.java }}
python_cdk: ${{ steps.changes.outputs.python_cdk }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduce python cdk change detection as we'd want to add a job to run python cdk tests


steps:
- name: Checkout Airbyte
uses: actions/checkout@v3
- name: Get changed files
uses: tj-actions/changed-files@v39
id: changes
- id: changes
uses: dorny/paths-filter@v2
with:
files_yaml: |
gradlecheck:
# Note: expressions within a filter are OR'ed
filters: |
java:
- '**/*.java'
- '**/*.gradle'
- 'airbyte-cdk/java/**/*'
outputs:
gradle: ${{ steps.changes.outputs.gradlecheck_any_changed }}

python_cdk:
- 'airbyte-cdk/python/**/*'
run-check:
needs:
- changes
if: needs.changes.outputs.gradle == 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may have failed because of a typo: gradle != gradlecheck

if: needs.changes.outputs.java == 'true'
# The gradle check task which we will run is embarrassingly parallelizable.
# We therefore run this on a machine with a maximum number of cores.
# We pay per time and per core, so there should be little difference in total cost.
Expand Down
Loading