Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Source Stripe bugfix: Update stripe data types to output number instead of int #3728

Merged
merged 5 commits into from
May 28, 2021
Merged

🐛Source Stripe bugfix: Update stripe data types to output number instead of int #3728

merged 5 commits into from
May 28, 2021

Commits on May 28, 2021

  1. Update stripe data types to number instead of int 

    For some reason a lot of integer fields are being output as `<value>.0` which breaks normalization. This is also happening in other sources, Shopify and Recurly. We need to root cause this issue or roll out a wider fix, perhaps using the CDK. For now, we're just trying to unblock the user.
    @sherifnada
    sherifnada authored May 28, 2021
    Configuration menu
    Copy the full SHA
    196ab4f View commit details
    Browse the repository at this point in the history

  2. Update invoices.json

    @sherifnada
    sherifnada authored May 28, 2021
    Configuration menu
    Copy the full SHA
    7d66efb View commit details
    Browse the repository at this point in the history

  3. Update Dockerfile

    @sherifnada
    sherifnada authored May 28, 2021
    Configuration menu
    Copy the full SHA
    3585872 View commit details
    Browse the repository at this point in the history

  4. Update source_definitions.yaml

    @sherifnada
    sherifnada authored May 28, 2021
    Configuration menu
    Copy the full SHA
    cb1b46c View commit details
    Browse the repository at this point in the history

  5. Update e094cb9a-26de-4645-8761-65c0c425d1de.json

    @sherifnada
    sherifnada authored May 28, 2021
    Configuration menu
    Copy the full SHA
    88579be View commit details
    Browse the repository at this point in the history