hotfix: Fix Build Misc #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhizor
approved these changes
Sep 22, 2020
davydov-d
added a commit
that referenced
this pull request
Sep 23, 2022
davydov-d
added a commit
that referenced
this pull request
Sep 23, 2022
* #481 oncall source fb marketing: limit time range to 37 months * source fb marketing: upd changelog * #391 source facebook-marketing: retry on getting error 960 * source facebook marketing: format code * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <[email protected]>
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
…7027) * airbytehq#481 oncall source fb marketing: limit time range to 37 months * source fb marketing: upd changelog * airbytehq#391 source facebook-marketing: retry on getting error 960 * source facebook marketing: format code * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <[email protected]>
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
…7027) * airbytehq#481 oncall source fb marketing: limit time range to 37 months * source fb marketing: upd changelog * airbytehq#391 source facebook-marketing: retry on getting error 960 * source facebook marketing: format code * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
image_existsscript was in scheduler resources, not workers resources. the integration tests only depend on workers, which meant they did not have access to the image_exists script when they needed to. moved image_exists into workers resources instead.image_existsscript that did not handle the case where the image does not exist in the remote and only exists locally causing postgres integration tests to fail. fixed.