Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy seed files from airbyte-config/init/build to airbyte-server to be used in migrations #4428

Conversation

cgardens
Copy link
Contributor

@cgardens cgardens commented Jun 30, 2021

closes #4412

What

  • We need airbyte-server to have access to the generated seed configs to make auto migration work. Instead of having those files live in airbyte-server we continue to generate them in airbyte-config:init but then copy them over to airbyte-server

How

  • gradle copy command

While doing this I discovered this bug: https://github.com/airbytehq/airbyte-internal-issues/issues/156. Going to suggest we follow up on it separately and focus on just getting this deduplication of configs fixed. I think the fallout from this bug will generally be low.


This change is Reviewable

@github-actions github-actions bot added the area/platform issues related to the platform label Jun 30, 2021
@subodh1810
Copy link
Contributor

Tested this locally and is working fine. Automatic migration is also working fine

…ens/share_resources_across_subprojects_part2
Copy link
Contributor

@subodh1810 subodh1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think I need to learn gradle better to be able to do these things. I have pushed few commits just to make like fixing tests and making sure everywhere we use airbyte-config now. Tested this locally as well and works fine.

Copy link
Contributor

@davinchia davinchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cgardens)

@cgardens cgardens merged commit b3e2ef6 into cgardens/share_resources_across_subprojects Jun 30, 2021
@cgardens cgardens deleted the cgardens/share_resources_across_subprojects_part2 branch June 30, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants