-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New API endpoint to search connections #4813
Merged
marcosmarxm
merged 11 commits into
airbytehq:master
from
mmolimar:feature/search-connection-endpoint
Sep 23, 2021
Merged
🎉 New API endpoint to search connections #4813
marcosmarxm
merged 11 commits into
airbytehq:master
from
mmolimar:feature/search-connection-endpoint
Sep 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api
Related to the api
area/platform
issues related to the platform
area/documentation
Improvements or additions to documentation
labels
Jul 19, 2021
thanks @mmolimar we're going to review soon! |
…arch-connection-endpoint
…arch-connection-endpoint
…arch-connection-endpoint
…arch-connection-endpoint
…arch-connection-endpoint
…arch-connection-endpoint
marcosmarxm
changed the title
New endpoint to search connections
🎉 New API endpoint to search connections
Sep 23, 2021
marcosmarxm
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @marcosmarxm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/api
Related to the api
area/documentation
Improvements or additions to documentation
area/platform
issues related to the platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds a new endpoint to search connections. The search is very flexible and can include 0 or more values in the payload including values from the connections, sources, and/or destinations (also look for values in the connection configuration).
How
Update the YAML file containing the endpoints with the specification and the WebBackendConnectionsHandler.
Recommended reading order
config.yml
WebBackendConnectionsHandler.java
ConfigurationApi.java
Pre-merge Checklist
Expand the checklist which is relevant for this PR.
Connector checklist
airbyte_secret
in the connector's spec./gradlew :airbyte-integrations:connectors:<name>:integrationTest
./test connector=connectors/<name>
command as documented here is passing.README.md
docs/SUMMARY.md
if it's a new connectordocs/integrations/<source or destination>/<name>
.docs/integrations/...
. See changelog exampledocs/integrations/README.md
contains a reference to the new connector/publish
command described hereConnector Generator checklist
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes