Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BigQuery source: Fix nested arrays #4981

Merged
merged 80 commits into from
Jul 27, 2021

Conversation

DoNotPanicUA
Copy link
Contributor

@DoNotPanicUA DoNotPanicUA commented Jul 26, 2021

What

A BigQuery source fails if data contains a column with the type Array of Records.
Docs are missing for the BigQuery source.

How

Implement proper handling of nested arrays and update documentation.

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

  • Documentation updated
    • README.md
    • docs/SUMMARY.md if it's a new connector
    • Created or updated reference docs in docs/integrations/<source or destination>/<name>.
    • Changelog in the appropriate page in docs/integrations/.... See changelog example
    • docs/integrations/README.md contains a reference to the new connector
    • Build status added to build page (Add Big Query to builds.md #5025)

DoNotPanicUA and others added 30 commits June 22, 2021 17:18
s not an abstract class.
+ add default implementation for `AbstractRelationalDbSource.getFullyQualifiedTableName`
…act-source

# Conflicts:
#	airbyte-integrations/connectors/source-mysql/src/main/java/io/airbyte/integrations/source/mysql/MySqlSource.java
# Conflicts:
#	airbyte-integrations/connectors/source-mysql/src/main/java/io/airbyte/integrations/source/mysql/MySqlSource.java
…nto aleonets/1876-source-bigquery

# Conflicts:
#	airbyte-integrations/connectors/source-mysql/src/main/java/io/airbyte/integrations/source/mysql/MySqlSource.java
@github-actions github-actions bot added the area/connectors Connector related issues label Jul 26, 2021
@DoNotPanicUA DoNotPanicUA changed the title Aleonets/1876 source bigquery 🐛 BigQuery source: Fix nested arrays Jul 27, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 27, 2021
@DoNotPanicUA DoNotPanicUA self-assigned this Jul 27, 2021
@DoNotPanicUA DoNotPanicUA marked this pull request as ready for review July 27, 2021 15:19
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- can you also merge this PR with yours, you'll need to also add the equivalent JSON entry #4929

This will add it to the list of connectors available by default

@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Jul 27, 2021

/test connector=source-bigquery

🕑 source-bigquery https://github.com/airbytehq/airbyte/actions/runs/1071926584
✅ source-bigquery https://github.com/airbytehq/airbyte/actions/runs/1071926584

@DoNotPanicUA
Copy link
Contributor Author

DoNotPanicUA commented Jul 27, 2021

/publish connector=connectors/source-bigquery

🕑 connectors/source-bigquery https://github.com/airbytehq/airbyte/actions/runs/1071957202
✅ connectors/source-bigquery https://github.com/airbytehq/airbyte/actions/runs/1071957202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bigquery connectors/sources-database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Bigquery: com.google.cloud.bigquery.BigQueryException: Arrays of arrays are not supported at
5 participants