Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sherif/publish pr 5339 #5450

Merged
merged 13 commits into from
Aug 17, 2021
Merged

Sherif/publish pr 5339 #5450

merged 13 commits into from
Aug 17, 2021

Conversation

sherifnada
Copy link
Contributor

@sherifnada sherifnada commented Aug 17, 2021 •
edited
Loading

publish #5339

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 17, 2021
@sherifnada
Copy link
Contributor Author

sherifnada commented Aug 17, 2021 •
edited by github-actions bot
Loading

/test connector=destination-keen

🕑 destination-keen https://github.com/airbytehq/airbyte/actions/runs/1137964812
❌ destination-keen https://github.com/airbytehq/airbyte/actions/runs/1137964812

@jrhizor jrhizor temporarily deployed to more-secrets August 17, 2021 04:35 Inactive
@sherifnada
Copy link
Contributor Author

sherifnada commented Aug 17, 2021 •
edited by github-actions bot
Loading

/test connector=destination-keen

🕑 destination-keen https://github.com/airbytehq/airbyte/actions/runs/1137977212
❌ destination-keen https://github.com/airbytehq/airbyte/actions/runs/1137977212

@jrhizor jrhizor temporarily deployed to more-secrets August 17, 2021 04:42 Inactive
@sherifnada
Copy link
Contributor Author

sherifnada commented Aug 17, 2021 •
edited by github-actions bot
Loading

/test connector=destination-keen

🕑 destination-keen https://github.com/airbytehq/airbyte/actions/runs/1140806536
❌ destination-keen https://github.com/airbytehq/airbyte/actions/runs/1140806536

@jrhizor jrhizor temporarily deployed to more-secrets August 17, 2021 20:56 Inactive
@sherifnada
Copy link
Contributor Author

sherifnada commented Aug 17, 2021 •
edited by github-actions bot
Loading

/test connector=destination-keen

🕑 destination-keen https://github.com/airbytehq/airbyte/actions/runs/1140882923
✅ destination-keen https://github.com/airbytehq/airbyte/actions/runs/1140882923

@jrhizor jrhizor temporarily deployed to more-secrets August 17, 2021 21:22 Inactive
@sherifnada
Copy link
Contributor Author

sherifnada commented Aug 17, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-keen

🕑 connectors/destination-keen https://github.com/airbytehq/airbyte/actions/runs/1140966806
✅ connectors/destination-keen https://github.com/airbytehq/airbyte/actions/runs/1140966806

@jrhizor jrhizor temporarily deployed to more-secrets August 17, 2021 21:54 Inactive
@sherifnada sherifnada merged commit 179d4b3 into master Aug 17, 2021
@sherifnada sherifnada deleted the sherif/publish-pr-5339 branch August 17, 2021 22:10
@tuliren
Copy link
Contributor

tuliren commented Sep 4, 2021

@sherifnada, why are there two destination-keen definitions?

@tuliren tuliren mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/keen connectors/destinations-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sherifnada @tuliren @jrhizor @karinakuz @maciej-nedza