-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: Marketo #5863
🎉 New Source: Marketo #5863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove your local test logs airbyte-integrations/connectors/source-marketo/acceptance_tests_logs
airbyte-integrations/connectors/source-marketo/source_marketo/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small corrections are needed.
airbyte-integrations/connectors/source-marketo/acceptance-test-config.yml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/schemas/activity_types.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/spec.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-marketo/source_marketo/source.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
did you also manage to run the /test
command? I don't see this on the PR.
/test connector=connectors/source-marketo
|
/test connector=connectors/source-marketo
|
/test connector=connectors/source-marketo
|
/test connector=connectors/source-marketo
|
Already approved by airbyte
/publish connector=connectors/source-marketo
|
/publish connector=connectors/source-marketo
|
/publish connector=connectors/source-marketo
|
What
#5240 - New Source: Marketo
How
Using CDK and custom methods implemented the connector logic for Marketo as a source for Airbyte.
Recommended reading order
x.java
y.python
Pre-merge Checklist
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here