-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source GitHub: Add option to pull commits from user-specified branches #5931
Conversation
I just realized this might break on reading existing Github state of previous versions. Any suggestions on how to resolve this? |
airbyte-integrations/connectors/source-github/source_github/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-github/source_github/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-github/source_github/streams.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments
@cjwooo Regarding this question.
|
@yevhenii-ldv This PR is ready for review again. |
Hey @cjwooo! Thank you! |
thanks a lot both! 🎉 |
Merged as #6223 |
What
Currently, the GitHub source only pulls commits from each repository's default branch. We want to pull commits from multiple branches.
How
Add an option to specify a space-delimited list of repository branches to pull commits for. If no branches are specified for a repository, the source will pull only the default branch as it does currently. Cursor field state is tracked per branch instead of per repository.
Recommended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes