-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Keen destination: fix for timestamp inference for complex types #5973
🐛 Keen destination: fix for timestamp inference for complex types #5973
Conversation
Thanks @maciej-nedza can you use the Update connector checklist to let us know what steps you are? Do you need any assistance or this is already ready to review? |
Hey @marcosmarxm , yes, it was already ready for the review. I've updated the checklist and bumped the version. |
@@ -88,12 +88,12 @@ | |||
- destinationDefinitionId: 8aaf41d0-f6d2-46de-9e79-c9540f828142 | |||
name: Keen | |||
dockerRepository: airbyte/destination-keen | |||
dockerImageTag: 0.1.0 | |||
dockerImageTag: 0.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've bumped versions here and in the <uuid>.json
file, however I don't see updated version number in settings -> Destination after launching the application. Should I do something more ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instances don't autoupdate versions for stability reasons. The user must update it by hand. Versions specified in this/the JSON files are used the very first time Airbyte runs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maciej-nedza !
@@ -88,12 +88,12 @@ | |||
- destinationDefinitionId: 8aaf41d0-f6d2-46de-9e79-c9540f828142 | |||
name: Keen | |||
dockerRepository: airbyte/destination-keen | |||
dockerImageTag: 0.1.0 | |||
dockerImageTag: 0.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instances don't autoupdate versions for stability reasons. The user must update it by hand. Versions specified in this/the JSON files are used the very first time Airbyte runs.
What
Fixed bug, when destination initialization during syncrhonization was failing for some particular sources which use schema composition for their field's types ( "allOf", "anyOf", "oneOf").
Also race condition causing randomly failing test runs should be finally fixed.
How
Simplified process of timestamp inference, now the map containing streams to cursorfFields mappings doesn't keep track of cursor's type. In process of inference, first the cursor is always tried to be parsed into number, if this fails then it's tried to be parsed into string.
Recommended reading order
x.java
y.python
Pre-merge Checklist
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here