MySql Source: Fix data processing #6093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd use common type mapping.
…fix-mysql # Conflicts: # airbyte-db/lib/src/main/java/io/airbyte/db/SourceOperations.java # airbyte-db/lib/src/main/java/io/airbyte/db/jdbc/JdbcSourceOperations.java
DoNotPanicUA
changed the title
DoNotPanicUA
changed the title
DoNotPanicUA
changed the title
github-actions
bot
added
the
area/documentation
alexandr-shegeda
approved these changes
Sep 21, 2021
|
@DoNotPanicUA I won't be able to get to this for 1 or 2 days, my apologies. Will leave a review in a couple of days |
…fix-mysql # Conflicts: # docs/integrations/sources/mysql.md
DoNotPanicUA
force-pushed
the
aleonets/3931-3932-fix-mysql
branch
from
3a6bc38
to
c4c4e85
Compare
…fix-mysql # Conflicts: # docs/integrations/sources/mysql.md
…avior=convertToNull"
…fix-mysql # Conflicts: # docs/integrations/sources/mysql.md
|
/test connector=source-mysql
|
sherifnada
approved these changes
Oct 12, 2021
| @@ -87,8 +87,9 @@ public JsonNode toJdbcConfig(JsonNode config) { | |||
| config.get("port").asText(), | |||
| config.get("database").asText())); | |||
|
|
|||
| jdbcUrl.append("?zeroDateTimeBehavior=convertToNull"); | |||
There was a problem hiding this comment.
we should add a note in the .md docs saying that zero date time is converted to null
...tination-mysql/src/main/java/io/airbyte/integrations/destination/mysql/MySQLDestination.java
Outdated
Show resolved
Hide resolved
| @@ -175,16 +176,16 @@ protected void initTests() { | |||
| TestDataHolder.builder() | |||
| .sourceType("float") | |||
| .airbyteType(JsonSchemaPrimitive.NUMBER) | |||
| .addInsertValues("null") | |||
| .addNullExpectedValue() | |||
| .addInsertValues("null", "10.5") | |||
…a/io/airbyte/integrations/destination/mysql/MySQLDestination.java Co-authored-by: Sherif A. Nada <[email protected]>
Co-authored-by: Sherif A. Nada <[email protected]>
|
/publish connector=connectors/source-mysql
|
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* move logic from static JdbcUtils to JdbcSourceOperations * format * Add methods for all types in order to have possibility rewrite them and use common type mapping. * Make BigQuery in line impl with JDBC changes * fix binary type * add database creations methods with sourceOperations input * add MySqlSourceOperations * fix processing * Fix CDC processing * format * add some tests for double and float * incr version * airbytehq#3931 airbytehq#3932 added zero-date converting to null param "zeroDateTimeBehavior=convertToNull" * remove old tests covered by data type tests + incr ver * Update airbyte-integrations/connectors/destination-mysql/src/main/java/io/airbyte/integrations/destination/mysql/MySQLDestination.java Co-authored-by: Sherif A. Nada <[email protected]> * Update docs/integrations/sources/mysql.md Co-authored-by: Sherif A. Nada <[email protected]> * add back comments to the data type mapping * incr config version Co-authored-by: Oleksandr Sheheda <[email protected]> Co-authored-by: Sherif A. Nada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix MySql source fails and wrong data type handlers.
Note that some cases are still relevant as driver restriction or another issue:
How
Implement MySql specific handlers for problem data types
Recommended reading order
MySQLConverter.java- CDCMySqlSourceOperations.java- Commonmysql.md- restrictionsPre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes