🎉 Destination Oracle - Added support for connection via ssh tunnel #6370
Conversation
github-actions
bot
added
area/connectors
VitaliiMaltsev
changed the title
VitaliiMaltsev
changed the title
VitaliiMaltsev
changed the title
VitaliiMaltsev
changed the title
VitaliiMaltsev
requested review from
etsybaev
and removed request for
DoNotPanicUA
| @@ -130,6 +130,8 @@ jobs: | |||
| MIXPANEL_INTEGRATION_TEST_CREDS: ${{ secrets.MIXPANEL_INTEGRATION_TEST_CREDS }} | |||
| MSSQL_RDS_TEST_CREDS: ${{ secrets.MSSQL_RDS_TEST_CREDS }} | |||
| PAYPAL_TRANSACTION_CREDS: ${{ secrets.SOURCE_PAYPAL_TRANSACTION_CREDS }} | |||
| ORACLE_SSH_KEY_TEST_CREDS: ${{ secrets.ORACLE_SSH_KEY_TEST_CREDS }} | |||
There was a problem hiding this comment.
can we instead use the approach you took in #5811 ?
There was a problem hiding this comment.
sure, i'll modify on container approach once #6312 will be merged
There was a problem hiding this comment.
@sherifnada I changed the integration tests for the bastion container approach
There was a problem hiding this comment.
@sherifnada also how do you think maybe we need to create separate tasks to also change the integration tests for Oracle Source, MySQL Source and Destination, MSSQL Source and Destination with docker bastion container?
There was a problem hiding this comment.
@VitaliiMaltsev yup let's create issues on the backlog to do this, and make sure with the team that any new SSH implementations follow the bastion approach
|
vmaltsev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…rets for Oracle db
|
/publish connector=connectors/destination-oracle
|
|
/publish connector=connectors/destination-oracle
|
VitaliiMaltsev
deleted the
vmaltsev/5969-oracle-destination-ssh-tunnel
branch
What
The goal of this PR is to add SSH only for the Oracle Destination. It does not try to deal with how it can be reused for other sources or destinations.
How
Handles injecting the SSH tunnel in the spec, check, getConsumer methods of Oracle Destination directly. This makes it relatively straightforward to inject without worrying about touching other jdbc dbs.
Tested with AWS EC2 bastion and RDS Oracle:
or
der
Recommended reading
x.javay.pythonPre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/SUMMARY.mddocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampledocs/integrations/README.mdairbyte-integrations/builds.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes