Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix amazon ads unittests and apply formatting #6609

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Fix amazon ads unittests and apply formatting #6609

merged 2 commits into from
Oct 1, 2021

Conversation

avida
Copy link
Contributor

@avida avida commented Oct 1, 2021

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 1, 2021
@avida avida temporarily deployed to more-secrets October 1, 2021 10:59 Inactive
@avida
Copy link
Contributor Author

avida commented Oct 1, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/1294767242
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/1294767242

@avida
Copy link
Contributor Author

avida commented Oct 1, 2021

Created this PR cause publishing failed on #6461 I suppose cause it was created from another repo

@jrhizor jrhizor temporarily deployed to more-secrets October 1, 2021 11:02 Inactive
@avida
Copy link
Contributor Author

avida commented Oct 1, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/1294805203
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/1294805203

@avida avida temporarily deployed to more-secrets October 1, 2021 11:12 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 1, 2021 11:12 Inactive
@harshithmullapudi
Copy link
Contributor

@avida looks like one test is failing you want me to fix that ?

@avida avida changed the title Tmp PR to publish amazon ads image Fix amazon ads unittests and apply formatting Oct 1, 2021
@avida avida temporarily deployed to more-secrets October 1, 2021 11:47 Inactive
@avida
Copy link
Contributor Author

avida commented Oct 1, 2021

@harshithmullapudi Ive already fixed tests, also I removed one day time shifting cause we have lookback parameter.

@avida
Copy link
Contributor Author

avida commented Oct 1, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/1294997738
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/1294997738

@jrhizor jrhizor temporarily deployed to more-secrets October 1, 2021 12:17 Inactive
@avida
Copy link
Contributor Author

avida commented Oct 1, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/1295138504
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/1295138504

@avida avida temporarily deployed to more-secrets October 1, 2021 13:03 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 1, 2021 13:04 Inactive
@avida avida merged commit f69fbbc into master Oct 1, 2021
@avida avida deleted the drezchykov/test-branch branch October 1, 2021 13:11
@jrhizor jrhizor mentioned this pull request Oct 1, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@avida @schlattk
Fix amazon ads unittests and apply formatting (airbytehq#6609)
0c847f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshithmullapudi harshithmullapudi harshithmullapudi approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/source/amazon-ads connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avida @harshithmullapudi @jrhizor @ycherniaiev