-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Oracle Source: Add encryption options #6616
Conversation
vmaltsev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
/test connector=connectors/source-oracle
|
/test connector=connectors/source-oracle
|
# Conflicts: # docs/integrations/sources/oracle.md
...nnectors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java
Outdated
Show resolved
Hide resolved
...nnectors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-oracle/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-oracle/src/main/resources/spec.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great pr, just left few comments regarding code style and backward compatibility.
/test connector=connectors/source-oracle
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice one!
/publish connector=connectors/source-oracle
|
# Conflicts: # docs/integrations/sources/oracle.md
/publish connector=connectors/source-oracle
|
* OracleSource add encryption * add tests * add tests * remove debug option from Dockerfile * add docs and fix unit tests * remove System.out.println * fix checkstyle | remove 'encryption' from required fields * update timeout to 30 seconds * bump version to 0.3.6 * bump version to 0.3.7 Co-authored-by: vmaltsev <[email protected]>
What
We want to support TLS encryption when connecting to the Oracle source.
How
Add 3 options to Oracle source spec : Unecrypted, Oracle Native Network Encryption and TLS(Server certificate verification)
m
Recomended reading order
x.java
y.python
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes