-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New search API endpoints for connections, sources, and destinations #6656
New search API endpoints for connections, sources, and destinations #6656
Conversation
…arch-api-endpoints
Mario thanks for your contribution! Can you run |
Done! @marcosmarxm |
…arch-api-endpoints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really nice! Thank you. I have a few nitpicks, and a comment about making the unit tests more thorough. But if you don't have bandwidth to make those changes, it's also fine. We an do it in a follow up PR.
airbyte-server/src/main/java/io/airbyte/server/handlers/helpers/ConnectionMatcher.java
Outdated
Show resolved
Hide resolved
airbyte-server/src/test/java/io/airbyte/server/handlers/ConnectionsHandlerTest.java
Show resolved
Hide resolved
…s/ConnectionMatcher.java Co-authored-by: LiRen Tu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
…airbytehq#6656) * Add API endpoints for connections, sources, and destinations * Updating tests * Tests for source and destination handlers * Reformat code * Update airbyte-server/src/main/java/io/airbyte/server/handlers/helpers/ConnectionMatcher.java Co-authored-by: LiRen Tu <[email protected]> * Adding tests * Format code Co-authored-by: LiRen Tu <[email protected]>
What
This PR adds a new endpoint to search connections, sources, and destinations. The search is very flexible and can include 0 or more values in the payload including values from the connections, sources, and/or destinations (also look for values in the connection configuration).
How
Update the YAML file containing the endpoints with the specification and the ConnectionsHandler, SourceHandler, and DestinationsHandler. Also, I've added a new
Matcher
interface in theio.airbyte.server.handlers.helpers
package.Recommended reading order
config.yml
ConnectionsHandler.java
SourceHandler.java
DestinationHandler.java
ConfigurationApi.java
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes