🎉Destination MySQl - added ssl strict encrypt connector #6763

etsybaev · 2021-10-05T10:58:14Z

What

We want to create secure-only versions of connectors that can be used in the Airbyte cloud. The idea is that these connectors inherently prevent certain insecure connections such as connecting to a database over the public internet without encryption.

How

Implemented it similarly to already existing destination-postgres (#6496)

Added new connector and tested on UI

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

etsybaev · 2021-10-05T17:28:41Z

/test connector=destination-mysql-strict-encrypt

🕑 destination-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1308656051
✅ destination-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1308656051
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    11      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     117      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 10      0   100%
	 normalization/transform_catalog/stream_processor.py                 349    199    43%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         143     36    75%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1039    391    62%

etsybaev · 2021-10-05T17:42:15Z

/test connector=destination-mysql

🕑 destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1308701751
🕑 destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1308701751
❌ destination-mysql https://github.com/airbytehq/airbyte/actions/runs/1308701751
🐛 https://gradle.com/s/ijyi5iv4o74cc

…-encrypt

…-encrypt # Conflicts: # docs/integrations/destinations/mysql.md

etsybaev · 2021-10-11T13:49:06Z

/test connector=destination-mysql-strict-encrypt

🕑 destination-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1329233000
✅ destination-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1329233000
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 370    218    41%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         151     39    74%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1073    413    62%

etsybaev · 2021-10-11T14:13:04Z

/publish connector=destination-mysql-strict-encrypt

❌ destination-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1329322084
❌ destination-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1329322084
❌ destination-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1329322084
❌ destination-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1329322084

…-encrypt

etsybaev · 2021-10-13T13:05:37Z

/publish connector=destination-mysql-strict-encrypt

❌ destination-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1337573725

tuliren · 2021-10-13T17:53:57Z

/test connector=connectors/destination-mysql-strict-encrypt

🕑 connectors/destination-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1338641502
✅ connectors/destination-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1338641502
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 370    218    41%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         151     39    74%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1073    413    62%

alexandr-shegeda · 2021-10-13T21:12:31Z

/publish connector=connectors/destination-mysql-strict-encrypt

🕑 connectors/destination-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1339289748
✅ connectors/destination-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1339289748

* [6423] Destination MySQl - added ssl strict encrypt connector

[6423] Destination MySQl - added ssl strict encrypt connector

afcc8c1

etsybaev linked an issue Oct 5, 2021 that may be closed by this pull request

Create a secure-only MySQL destination #6423

Closed

6 tasks

github-actions bot added area/connectors Connector related issues area/worker Related to worker labels Oct 5, 2021

etsybaev temporarily deployed to more-secrets October 5, 2021 10:58 Inactive

[6423] Destination MySQl - fixed tests and checkstyle

2fb7ee6

etsybaev temporarily deployed to more-secrets October 5, 2021 11:43 Inactive

etsybaev added 2 commits October 5, 2021 17:44

[6423] Destination MySQl - added README.md

9777b67

[6423] Destination MySQl - Added changelog

647b3af

etsybaev requested review from alexandr-shegeda and VitaliiMaltsev October 5, 2021 15:22

alexandr-shegeda approved these changes Oct 5, 2021

View reviewed changes

etsybaev temporarily deployed to more-secrets October 5, 2021 15:38 Inactive

github-actions bot added the area/documentation Improvements or additions to documentation label Oct 5, 2021

jrhizor temporarily deployed to more-secrets October 5, 2021 15:46 Inactive

etsybaev temporarily deployed to more-secrets October 5, 2021 16:20 Inactive

jrhizor temporarily deployed to more-secrets October 5, 2021 17:00 Inactive

jrhizor temporarily deployed to more-secrets October 5, 2021 17:31 Inactive

jrhizor temporarily deployed to more-secrets October 5, 2021 17:44 Inactive

jrhizor temporarily deployed to more-secrets October 6, 2021 05:41 Inactive

Merge branch 'master' into etsybaev/6423-destination-mysql-ssl-strict…

1f64d27

…-encrypt

etsybaev temporarily deployed to more-secrets October 6, 2021 06:43 Inactive

etsybaev temporarily deployed to more-secrets October 6, 2021 09:25 Inactive

Merge branch 'master' into etsybaev/6423-destination-mysql-ssl-strict…

36bacce

…-encrypt

etsybaev temporarily deployed to more-secrets October 6, 2021 09:45 Inactive

fixed code style for changes from master

ceaaf1a

etsybaev temporarily deployed to more-secrets October 6, 2021 10:56 Inactive

etsybaev temporarily deployed to more-secrets October 6, 2021 11:15 Inactive

Merge branch 'master' into etsybaev/6423-destination-mysql-ssl-strict…

692c661

…-encrypt # Conflicts: # docs/integrations/destinations/mysql.md

etsybaev temporarily deployed to more-secrets October 11, 2021 12:44 Inactive

jrhizor temporarily deployed to more-secrets October 11, 2021 13:51 Inactive

jrhizor temporarily deployed to more-secrets October 11, 2021 14:15 Inactive

jrhizor temporarily deployed to more-secrets October 11, 2021 14:54 Inactive

jrhizor temporarily deployed to more-secrets October 11, 2021 17:41 Inactive

jrhizor temporarily deployed to more-secrets October 11, 2021 19:08 Inactive

Merge branch 'master' into etsybaev/6423-destination-mysql-ssl-strict…

f363e90

…-encrypt

etsybaev temporarily deployed to more-secrets October 12, 2021 06:15 Inactive

fixed checkstyle

4e40b92

etsybaev temporarily deployed to more-secrets October 12, 2021 07:33 Inactive

etsybaev temporarily deployed to more-secrets October 12, 2021 09:04 Inactive

etsybaev temporarily deployed to more-secrets October 12, 2021 10:53 Inactive

Merge branch 'master' into etsybaev/6423-destination-mysql-ssl-strict…

46ed4ac

…-encrypt

etsybaev temporarily deployed to more-secrets October 12, 2021 11:57 Inactive

etsybaev temporarily deployed to more-secrets October 12, 2021 21:38 Inactive

Merge branch 'master' into etsybaev/6423-destination-mysql-ssl-strict…

6176275

…-encrypt

etsybaev temporarily deployed to more-secrets October 13, 2021 12:32 Inactive

jrhizor temporarily deployed to more-secrets October 13, 2021 13:08 Inactive

jrhizor temporarily deployed to more-secrets October 13, 2021 17:56 Inactive

jrhizor temporarily deployed to more-secrets October 13, 2021 21:14 Inactive

etsybaev merged commit 05e09af into master Oct 14, 2021

etsybaev deleted the etsybaev/6423-destination-mysql-ssl-strict-encrypt branch October 14, 2021 05:28

jrhizor mentioned this pull request Oct 19, 2021

Bump Airbyte version from 0.30.20-alpha to 0.30.21-alpha #7145

Merged

schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022

🎉Destination MySQl - added ssl strict encrypt connector (airbytehq#6763)

d4b5b99

* [6423] Destination MySQl - added ssl strict encrypt connector

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉Destination MySQl - added ssl strict encrypt connector #6763

🎉Destination MySQl - added ssl strict encrypt connector #6763

etsybaev commented Oct 5, 2021 •

edited

Loading

etsybaev commented Oct 5, 2021 •

edited by github-actions bot

Loading

etsybaev commented Oct 5, 2021 •

edited by github-actions bot

Loading

etsybaev commented Oct 11, 2021 •

edited by github-actions bot

Loading

etsybaev commented Oct 11, 2021 •

edited by github-actions bot

Loading

etsybaev commented Oct 13, 2021 •

edited by github-actions bot

Loading

tuliren commented Oct 13, 2021 •

edited by github-actions bot

Loading

alexandr-shegeda commented Oct 13, 2021 •

edited by github-actions bot

Loading

🎉Destination MySQl - added ssl strict encrypt connector #6763

🎉Destination MySQl - added ssl strict encrypt connector #6763

Conversation

etsybaev commented Oct 5, 2021 • edited Loading

What

How

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

etsybaev commented Oct 5, 2021 • edited by github-actions bot Loading

etsybaev commented Oct 5, 2021 • edited by github-actions bot Loading

etsybaev commented Oct 11, 2021 • edited by github-actions bot Loading

etsybaev commented Oct 11, 2021 • edited by github-actions bot Loading

etsybaev commented Oct 13, 2021 • edited by github-actions bot Loading

tuliren commented Oct 13, 2021 • edited by github-actions bot Loading

alexandr-shegeda commented Oct 13, 2021 • edited by github-actions bot Loading

etsybaev commented Oct 5, 2021 •

edited

Loading

etsybaev commented Oct 5, 2021 •

edited by github-actions bot

Loading

etsybaev commented Oct 5, 2021 •

edited by github-actions bot

Loading

etsybaev commented Oct 11, 2021 •

edited by github-actions bot

Loading

etsybaev commented Oct 11, 2021 •

edited by github-actions bot

Loading

etsybaev commented Oct 13, 2021 •

edited by github-actions bot

Loading

tuliren commented Oct 13, 2021 •

edited by github-actions bot

Loading

alexandr-shegeda commented Oct 13, 2021 •

edited by github-actions bot

Loading