Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Stripe: Fix missing start_date argument + update json files for SAT #6841

Merged
merged 6 commits into from
Oct 7, 2021
Merged

🐛 Source Stripe: Fix missing start_date argument + update json files for SAT #6841

merged 6 commits into from
Oct 7, 2021

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented Oct 6, 2021 •
edited
Loading

What

Closes #6749.

Pre-merge Checklist

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

@Zirochkaa Zirochkaa self-assigned this Oct 6, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Oct 6, 2021
@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 6, 2021 16:12 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 6, 2021
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 6, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1312722539
✅ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1312722539
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	   self._warn("No data was collected.", slug="no-data-collected")
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_stripe/__init__.py       2      2     0%
	 source_stripe/source.py        20     20     0%
	 source_stripe/streams.py      167    167     0%
	 -----------------------------------------------
	 TOTAL                         189    189     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_stripe/__init__.py       2      0   100%
	 source_stripe/source.py        20     10    50%
	 source_stripe/streams.py      167     64    62%
	 -----------------------------------------------
	 TOTAL                         189     74    61%

@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 6, 2021 16:15 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 6, 2021 16:16 Inactive
htrueman
htrueman approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@htrueman htrueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few small suggestions added

airbyte-integrations/connectors/source-stripe/source_stripe/source.py Show resolved Hide resolved
airbyte-integrations/connectors/source-stripe/source_stripe/streams.py Outdated Show resolved Hide resolved
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 7, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1317668527
❌ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1317668527
🐛

@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 7, 2021 19:43 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 7, 2021 19:44 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 7, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1317683358
❌ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1317683358
🐛 https://gradle.com/s/7fwle4omz5gfo

@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 7, 2021 19:48 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 7, 2021 19:49 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 7, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1317704636
❌ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1317704636
🐛 https://gradle.com/s/inybbwxepix2i

@jrhizor jrhizor temporarily deployed to more-secrets October 7, 2021 19:56 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 7, 2021 •
edited by github-actions bot
Loading

/test connector=source-stripe

🕑 source-stripe https://github.com/airbytehq/airbyte/actions/runs/1317786189
✅ source-stripe https://github.com/airbytehq/airbyte/actions/runs/1317786189
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	   self._warn("No data was collected.", slug="no-data-collected")
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_stripe/__init__.py       2      2     0%
	 source_stripe/source.py        22     22     0%
	 source_stripe/streams.py      167    167     0%
	 -----------------------------------------------
	 TOTAL                         191    191     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_stripe/__init__.py       2      0   100%
	 source_stripe/source.py        22     11    50%
	 source_stripe/streams.py      167     64    62%
	 -----------------------------------------------
	 TOTAL                         191     75    61%

@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 7, 2021 20:21 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 7, 2021 20:22 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 7, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1317829614
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1317829614

@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 7, 2021 20:35 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 7, 2021 20:36 Inactive
@Zirochkaa Zirochkaa merged commit 4769819 into master Oct 7, 2021
@Zirochkaa Zirochkaa deleted the oleh/6749-fix-stripe-start_date-error branch October 7, 2021 20:50
@jrhizor jrhizor mentioned this pull request Oct 8, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@Zirochkaa @schlattk
🐛 Source Stripe: Fix missing start_date argument + update json file…
08d00b3 
…s for SAT (airbytehq#6841)

* Fix missing `start_date` argument + update json files for SAT

* Update docs

* Implement change request

* Update unit_tests

* Bump connector's version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htrueman htrueman htrueman approved these changes

@sherifnada sherifnada sherifnada approved these changes

@yevhenii-ldv yevhenii-ldv Awaiting requested review from yevhenii-ldv

@avida avida Awaiting requested review from avida

Assignees

@Zirochkaa Zirochkaa

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Stripe: type error missing start_date argument
4 participants
@Zirochkaa @sherifnada @htrueman @jrhizor