Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉Destination MSSQL: Fix the Acceptance Tests based on Normalization #6877

Merged
merged 5 commits into from
Oct 11, 2021
Merged

🎉Destination MSSQL: Fix the Acceptance Tests based on Normalization #6877

merged 5 commits into from
Oct 11, 2021

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Oct 7, 2021 •
edited
Loading

What

#6876 - Destination MSSQL: support normalization on destination-mssql destination connector

Already done within this PR

DESTINATION-MSSQL

  • enabled normalization option in spec.json for destination-mssql
  • enabled append+deduplication sync mode for destination-mssql
  • edited CHANGELOG in .../docs/integration/destinations/mssql
  • added normalization notes to .../docs/integration/destinations/mssql
  • bumped the version of destination-mssql to 0.1.10

What should be FIxed?

We need to fix the following tests to pass the integrationTest correctly:
SshKeyMSSQLDestinationAcceptanceTest.java
SshMSSQLDestinationAcceptanceTest.java
SshPasswordMSSQLDestinationAcceptanceTest.java

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@bazarnov bazarnov temporarily deployed to more-secrets October 7, 2021 15:53 Inactive
@github-actions github-actions bot added the area/connectors Connector related issues label Oct 7, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 7, 2021
@bazarnov bazarnov linked an issue Oct 7, 2021 that may be closed by this pull request
🎉 Destination MSSQL: support normalization on destination-mssql destination connector #6876
Closed
@bazarnov bazarnov mentioned this pull request Oct 7, 2021
Closed
@bazarnov bazarnov temporarily deployed to more-secrets October 7, 2021 15:56 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 8, 2021 14:04 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 8, 2021 14:30 Inactive
@etsybaev
Copy link
Contributor

etsybaev commented Oct 8, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1320914591
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1320914591
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 357    207    42%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         151     39    74%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1060    402    62%

@jrhizor jrhizor temporarily deployed to more-secrets October 8, 2021 15:29 Inactive
@etsybaev
Copy link
Contributor

etsybaev commented Oct 8, 2021

Selection_105

@etsybaev etsybaev temporarily deployed to more-secrets October 8, 2021 18:46 Inactive
@etsybaev
Merge branch 'master' into mssql-support-normalization
dc07c6c 
# Conflicts:
#	docs/integrations/destinations/mssql.md
@etsybaev etsybaev temporarily deployed to more-secrets October 10, 2021 11:34 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 10, 2021 11:59 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 10, 2021 12:24 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 10, 2021 13:55 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 10, 2021 16:46 Inactive
@etsybaev etsybaev temporarily deployed to more-secrets October 11, 2021 05:34 Inactive
@etsybaev
Copy link
Contributor

etsybaev commented Oct 11, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1327774446
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1327774446
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 370    218    41%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         151     39    74%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1073    413    62%

@jrhizor jrhizor temporarily deployed to more-secrets October 11, 2021 06:25 Inactive
@etsybaev etsybaev requested a review from tuliren October 11, 2021 12:52
@etsybaev
Copy link
Contributor

etsybaev commented Oct 11, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1330040040
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/1330040040

@etsybaev etsybaev changed the title Destination MSSQL: Fix the Acceptance Tests based on Normalization 🎉Destination MSSQL: Fix the Acceptance Tests based on Normalization Oct 11, 2021
@jrhizor jrhizor temporarily deployed to more-secrets October 11, 2021 17:58 Inactive
@etsybaev etsybaev merged commit 6fb989f into master Oct 11, 2021
@etsybaev etsybaev deleted the mssql-support-normalization branch October 11, 2021 18:58
@jrhizor jrhizor mentioned this pull request Oct 13, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@bazarnov @etsybaev @schlattk
🎉Destination MSSQL: Fix the Acceptance Tests based on Normalization (a…
13b65f3 
…irbytehq#6877)

* Enabled Normalization for destination-mssql

* added changelog

* fixed normalization for mssql source

Co-authored-by: ievgeniit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliren tuliren tuliren approved these changes

@irynakruk irynakruk irynakruk approved these changes

@alexandr-shegeda alexandr-shegeda Awaiting requested review from alexandr-shegeda

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🎉 Destination MSSQL: support normalization on destination-mssql destination connector
5 participants
@bazarnov @etsybaev @tuliren @irynakruk @jrhizor