Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Destination Oracle: implemented connection encryption using N… #6893

Merged
merged 4 commits into from
Oct 12, 2021
Merged

🎉 Destination Oracle: implemented connection encryption using N… #6893

merged 4 commits into from
Oct 12, 2021

Conversation

alexandr-shegeda
Copy link
Contributor

@alexandr-shegeda alexandr-shegeda commented Oct 8, 2021 •
edited
Loading

What

We want to support TLS encryption when connecting to the Oracle destination.

How

Added 3 options to the Oracle destination spec: Unencrypted, Oracle Native Network Encryption, and TLS(Server certificate verification)

Recommended reading order

  1. OracleDestination.java
  2. OracleDestinationAcceptanceTest.java
  3. OracleDestinationNneAcceptanceTest.java

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 8, 2021
@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets October 8, 2021 12:48 Inactive
@alexandr-shegeda
Copy link
Contributor Author

alexandr-shegeda commented Oct 8, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1320366751
✅ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1320366751
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    11      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     117      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 10      0   100%
	 normalization/transform_catalog/stream_processor.py                 349    199    43%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         143     36    75%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1039    391    62%

@jrhizor jrhizor temporarily deployed to more-secrets October 8, 2021 12:54 Inactive
@alexandr-shegeda alexandr-shegeda linked an issue Oct 8, 2021 that may be closed by this pull request
Add support for Oracle destination via TLS/SSL #6013
Closed
5 tasks
@alexandr-shegeda alexandr-shegeda changed the title #6013 🎉 Destination Oracle: implemented connection encryption using N… 🎉 Destination Oracle: implemented connection encryption using N… Oct 8, 2021
@alexandr-shegeda alexandr-shegeda requested review from subodh1810 and tuliren and removed request for subodh1810 October 8, 2021 13:49
tuliren
tuliren approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Only a few nitpicks.

Given that all the existing oracle acceptance test classes have prefixes, to make the class names more consistent, what about the following name changes:

  • OracleDestinationAcceptanceTest -> UnencryptedOracleDestinationAcceptanceTest
  • OracleDestinationNneAcceptanceTest -> NneOracleDestinationAcceptanceTest

...ation-oracle/src/main/java/io/airbyte/integrations/destination/oracle/OracleDestination.java Outdated Show resolved Hide resolved
airbyte-integrations/connectors/destination-oracle/src/main/resources/spec.json Outdated Show resolved Hide resolved
docs/integrations/destinations/oracle.md Outdated Show resolved Hide resolved
@tuliren
Copy link
Contributor

tuliren commented Oct 8, 2021

Oh, also don't forget to bump the connector version in its Dockerfile, and publish the connector.

@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets October 12, 2021 10:09 Inactive
@alexandr-shegeda
Copy link
Contributor Author

alexandr-shegeda commented Oct 12, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1332622858
✅ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1332622858
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    12      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     120      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 11      0   100%
	 normalization/transform_catalog/stream_processor.py                 370    218    41%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         151     39    74%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1073    413    62%

@jrhizor jrhizor temporarily deployed to more-secrets October 12, 2021 10:11 Inactive
@alexandr-shegeda
Copy link
Contributor Author

alexandr-shegeda commented Oct 12, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-oracle

🕑 connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1332975909
✅ connectors/destination-oracle https://github.com/airbytehq/airbyte/actions/runs/1332975909

@jrhizor jrhizor temporarily deployed to more-secrets October 12, 2021 12:02 Inactive
@alexandr-shegeda alexandr-shegeda temporarily deployed to more-secrets October 12, 2021 13:46 Inactive
@alexandr-shegeda alexandr-shegeda merged commit 2b39c11 into master Oct 12, 2021
@alexandr-shegeda alexandr-shegeda deleted the asheg/6013-destination-oracle-add-encryption branch October 12, 2021 15:20
@jrhizor jrhizor mentioned this pull request Oct 13, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@alexandr-shegeda @schlattk
🎉 Destination Oracle: implemented connection encryption using N… (air…
06fd641 
…bytehq#6893)

* airbytehq#6013 🎉 Destination Oracle: implemented connection encryption using NNE and TLS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliren tuliren tuliren approved these changes

@irynakruk irynakruk irynakruk approved these changes

@VitaliiMaltsev VitaliiMaltsev VitaliiMaltsev approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Oracle destination via TLS/SSL
5 participants
@alexandr-shegeda @tuliren @irynakruk @VitaliiMaltsev @jrhizor