Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Gitlab: fix pattern field in spec file, remove unused fields from config files, improve caching mechanism #6932

Merged
merged 4 commits into from
Oct 12, 2021
Merged

🐛 Source Gitlab: fix pattern field in spec file, remove unused fields from config files, improve caching mechanism #6932

merged 4 commits into from
Oct 12, 2021

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented Oct 9, 2021 •
edited
Loading

Closes #6822.
Fix how cache is being used in this connector.
Fix pattern field in spec file.
Remove unused fields from invalid_config.json and sample_config.json files.

Pre-merge Checklist

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

@Zirochkaa
Fix SAT
15bd5c5 
Fix how cache is used in this connector.
Fix pattern field in spec file.
Remove unused fields from invalid_config.json and sample_config.json files.
@Zirochkaa Zirochkaa self-assigned this Oct 9, 2021
@github-actions github-actions bot added the area/connectors Connector related issues label Oct 9, 2021
@Zirochkaa Zirochkaa changed the title 🐛 Source Gitlab: fix spec file, remove unused fields from config files, improve caching mechanism 🐛 Source Gitlab: fix pattern field in spec file, remove unused fields from config files, improve caching mechanism Oct 9, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Oct 9, 2021
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 9, 2021 •
edited by github-actions bot
Loading

/test connector=source-gitlab

🕑 source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1323768233
❌ source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1323768233
🐛 https://gradle.com/s/bethu6ypb7hw4

@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 9, 2021 15:09 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 9, 2021 15:11 Inactive
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 9, 2021 •
edited by github-actions bot
Loading

/test connector=source-gitlab

🕑 source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1323795273
✅ source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1323795273
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_gitlab/__init__.py       2      2     0%
	 source_gitlab/source.py        36     36     0%
	 source_gitlab/streams.py      253    253     0%
	 -----------------------------------------------
	 TOTAL                         291    291     0%

@jrhizor jrhizor temporarily deployed to more-secrets October 9, 2021 15:26 Inactive
avida
avida suggested changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@avida avida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use caching features provided by CDK

@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 11, 2021 •
edited by github-actions bot
Loading

/test connector=source-gitlab

🕑 source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1330399236
✅ source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1330399236
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 /actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-gitlab/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 -----------------------------------------------
	 source_gitlab/__init__.py       2      2     0%
	   self._warn("No data was collected.", slug="no-data-collected")
	 source_gitlab/source.py        36     36     0%
	 source_gitlab/streams.py      220    220     0%
	 -----------------------------------------------
	 TOTAL                         258    258     0%

@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 11, 2021 20:02 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 11, 2021 20:03 Inactive
@Zirochkaa Zirochkaa requested a review from avida October 11, 2021 20:07
avida
avida approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@avida avida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont forget to bump version on dockerfile and airbyte-config dir

@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Oct 12, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-gitlab

🕑 connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1332076689
✅ connectors/source-gitlab https://github.com/airbytehq/airbyte/actions/runs/1332076689

@Zirochkaa Zirochkaa temporarily deployed to more-secrets October 12, 2021 07:33 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets October 12, 2021 07:34 Inactive
@Zirochkaa Zirochkaa merged commit 51a2e45 into master Oct 12, 2021
@Zirochkaa Zirochkaa deleted the oleh/6822-fix-gitlab-build branch October 12, 2021 07:39
@jrhizor jrhizor mentioned this pull request Oct 13, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@Zirochkaa @schlattk
🐛 Source Gitlab: fix pattern field in spec file, remove unused fields…
9e02e2a 
… from config files, improve caching mechanism (airbytehq#6932)

* Fix SAT

Fix how cache is used in this connector.
Fix pattern field in spec file.
Remove unused fields from invalid_config.json and sample_config.json files.

* Update docs

* Use cache from CDK

* Bump connector's version + update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avida avida avida approved these changes

@davinchia davinchia davinchia approved these changes

@htrueman htrueman htrueman approved these changes

@yevhenii-ldv yevhenii-ldv Awaiting requested review from yevhenii-ldv

@sherifnada sherifnada Awaiting requested review from sherifnada

@Phlair Phlair Awaiting requested review from Phlair

Assignees

@Zirochkaa Zirochkaa

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/gitlab connectors/sources-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Gitlab connector build , add credentials to lastpass
6 participants
@Zirochkaa @avida @davinchia @htrueman @jrhizor @igrankova