SAT: Improve message about errors in stream's schema #6934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avida
approved these changes
Oct 11, 2021
davinchia
reviewed
Oct 12, 2021
| @@ -201,7 +201,7 @@ def _validate_schema(records: List[AirbyteRecordMessage], configured_catalog: Co | |||
| for stream_name, errors in streams_errors.items(): | |||
| errors = map(str, errors.values()) | |||
| str_errors = f"\n{bar}\n".join(errors) | |||
| logging.error(f"The {stream_name} stream has the following schema errors:\n{str_errors}") | |||
| logging.error(f"\nThe {stream_name} stream has the following schema errors:\n{str_errors}") | |||
There was a problem hiding this comment.
this is a strange way to do this, is it possible to place the newline on the previous log line instead of the new log line?
There was a problem hiding this comment.
This part:
is being added automatically by logging.error().
And what we pass to logging.error() will be right next to above text:
So we can't place the newline on the previous log line instead of the new log line.
There was a problem hiding this comment.
got it. thanks for the explanation.
davinchia
approved these changes
Oct 12, 2021
|
/publish connector=bases/source-acceptance-test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #6933.
Now it looks like this: