Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New Source: OneSignal #6998

Merged
merged 9 commits into from
Oct 22, 2021
Merged

Conversation

burmecia
Copy link
Contributor

@burmecia burmecia commented Oct 13, 2021

What

How

Add four streams for this source:

  1. Apps
  2. Devices
  3. Notifications
  4. Outcomes

Recommended reading order

  1. bootstrap.md
  2. spec.json
  3. Schemas under schemas/*.json
  4. source.py
  5. streams.py

Test Runs

unit test
unit-test

integration test
int-test

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 13, 2021
@marcosmarxm
Copy link
Member

Thanks @burmecia for this awesome contribution! We're going to review this tomorrow or max by Friday.

@antixar antixar self-requested a review October 18, 2021 12:07
Copy link
Contributor

@antixar antixar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
But we need to sort out with 2 following points:

  • overridden protected python CDK function
  • backoff logic

@burmecia
Copy link
Contributor Author

thank you @antixar for your detailed suggestions, I will have have a look today and get back to you soon.

@antixar
Copy link
Contributor

antixar commented Oct 21, 2021

Hi @burmecia,
Thank you for your job!
We're gonna add your connector to our CI tests and after their passed result we will merge it.

@antixar antixar self-requested a review October 21, 2021 17:21
@marcosmarxm marcosmarxm merged commit fac6840 into airbytehq:master Oct 22, 2021
@burmecia burmecia deleted the new-source-onesignal branch October 22, 2021 04:21
@igrankova
Copy link
Contributor

@marcosmarxm, hi. Can you specify the task for vetting here? What actions needed from the unblockers' side?

schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* add source onesignal

* update PR number in change log

* change source define cursor and sync mode

* get correct max cursor time across stream slices

* code improvement as code review advices

* format code

* remove unused code

* remove TODOs

Co-authored-by: Maksym Pavlenok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/onesignal gl
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

7 participants