-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source: OneSignal #6998
🎉 New Source: OneSignal #6998
Conversation
Thanks @burmecia for this awesome contribution! We're going to review this tomorrow or max by Friday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
But we need to sort out with 2 following points:
- overridden protected python CDK function
- backoff logic
airbyte-integrations/connectors/source-onesignal/source_onesignal/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-onesignal/source_onesignal/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-onesignal/source_onesignal/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-onesignal/source_onesignal/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-onesignal/source_onesignal/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-onesignal/source_onesignal/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-onesignal/source_onesignal/streams.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-onesignal/unit_tests/test_streams.py
Show resolved
Hide resolved
airbyte-integrations/connectors/source-onesignal/source_onesignal/source.py
Show resolved
Hide resolved
thank you @antixar for your detailed suggestions, I will have have a look today and get back to you soon. |
Hi @burmecia, |
@marcosmarxm, hi. Can you specify the task for vetting here? What actions needed from the unblockers' side? |
* add source onesignal * update PR number in change log * change source define cursor and sync mode * get correct max cursor time across stream slices * code improvement as code review advices * format code * remove unused code * remove TODOs Co-authored-by: Maksym Pavlenok <[email protected]>
What
How
Add four streams for this source:
Recommended reading order
Test Runs
unit test
integration test
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described here