🎉 Source Stripe: add checkout_sessions stream, checkout_sessions_line_item stream and promotion_codes stream #7345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-remar
commented
Oct 25, 2021
| data = response_json.get("data", []) | ||
| if data: | ||
| for e in data: | ||
| checkout_session_id = re.search(r'/sessions/(cs_[^/].+)/line_items', response.url) |
There was a problem hiding this comment.
Here the checkout_session_id is saved into the line_items response, since it is not included line_items response.
…on schema and requests_params
|
thanks @vladimir-remar I asked the team to review your contribution. |
vladimir-remar
changed the title
Zirochkaa
suggested changes
Oct 27, 2021
There was a problem hiding this comment.
lgtm, just a few comments
Also, could you please add these 3 new streams to integration tests?
- CheckoutSessions and CheckoutSessionsLineItems to
integration_tests/full_refresh_configured_catalog.json; - PromotionCodes to
non_invoice_line_items_catalogfile. Also please add data for PromotionCodes stream tointegration_tests/abnormal_state.jsonfile.
After doing this, could you please post here results of integration tests?
Also could you please add all 3 streams to integration_tests/configured_catalog.json file?
airbyte-integrations/connectors/source-stripe/source_stripe/schemas/promotion_codes.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-stripe/source_stripe/schemas/promotion_codes.json
Outdated
Show resolved
Hide resolved
...ntegrations/connectors/source-stripe/source_stripe/schemas/checkout_sessions_line_items.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-stripe/source_stripe/schemas/checkout_sessions.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-stripe/source_stripe/schemas/promotion_codes.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-stripe/source_stripe/schemas/checkout_sessions.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-stripe/source_stripe/schemas/checkout_sessions.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-stripe/source_stripe/schemas/checkout_sessions.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-stripe/source_stripe/streams.py
Outdated
Show resolved
Hide resolved
|
Hi! @Zirochkaa, thanks for the comments. I did the changes. |
Zirochkaa
suggested changes
Oct 31, 2021
There was a problem hiding this comment.
@vladimir-remar nice work, just 2 comments and we are good to go.
airbyte-integrations/connectors/source-stripe/source_stripe/streams.py
Outdated
Show resolved
Hide resolved
...ntegrations/connectors/source-stripe/source_stripe/schemas/checkout_sessions_line_items.json
Outdated
Show resolved
Hide resolved
Zirochkaa
approved these changes
Nov 4, 2021
…om:vladimir-remar/airbyte into marcos/test-pr-7345
|
|
github-actions
bot
added
area/documentation
16 tasks
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
…_item stream and promotion_codes stream (airbytehq#7345) * update: add checkout_sessions and checkout_sessions_line_item streams * update: add discount object to checkout_session_line_items, update json schema and requests_params * fix: checkout_session_line_items json schema * update: add new stream promotion_codes * fix: json schemas * fix: checkout sessions line items json schema * update: add new streams to integration tests * format streams file * fix type in checkout_sessions_line_items json schema * update parse_response in CheckoutSessionsLineItems * bump version + docs * generate seed and format Co-authored-by: Marcos Marx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add new streams for checkout sessions and checkout session line items.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described here