fixed bug which crashes okta log incremental sync #7584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
marcosmarxm
reviewed
Nov 3, 2021
| @@ -82,17 +83,22 @@ def cursor_field(self) -> str: | |||
| pass | |||
|
|
|||
| def get_updated_state(self, current_stream_state: MutableMapping[str, Any], latest_record: Mapping[str, Any]) -> Mapping[str, Any]: | |||
| lowest_date = str(pendulum.datetime.min) | |||
| lowest_date = str(datetime.min) | |||
There was a problem hiding this comment.
why this change from pendulum to datetime?
There was a problem hiding this comment.
pendulum.datetime.min wasn't resolving on my machine.
There was a problem hiding this comment.
you need to run tests with pyenv activated
There was a problem hiding this comment.
I reverted it back to pendulum
marcosmarxm
approved these changes
Nov 3, 2021
lmossman
pushed a commit
that referenced
this pull request
Nov 3, 2021
* fixed bug which crashes okta log incremental sync * bump connector version * revert to pendulum
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* fixed bug which crashes okta log incremental sync * bump connector version * revert to pendulum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Okta logs failed when doing an incremental sync.
How
The logs endpoint uses different filtering from the users and groups endpoints. Instead of using a query param called
filter, it uses a query param calledsince. Here's Okta's documentation on this.Recommended reading order
airbyte-integrations/connectors/source-okta/source_okta/source.pyairbyte-integrations/connectors/source-okta/integration_tests/configured_catalog.jsonPre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing./publishcommand described here