Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source OneSignal: correct get_update_state and unit test #7617

Merged
merged 4 commits into from
Nov 11, 2021
Merged

Source OneSignal: correct get_update_state and unit test #7617

merged 4 commits into from
Nov 11, 2021

Conversation

marcosmarxm
Copy link
Member

What

I removed a complex logic to get the update state from this connector.
Closes #7615

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added the area/connectors Connector related issues label Nov 4, 2021
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Nov 4, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-onesignal

🕑 connectors/source-onesignal https://github.com/airbytehq/airbyte/actions/runs/1419450770
✅ connectors/source-onesignal https://github.com/airbytehq/airbyte/actions/runs/1419450770
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       33     22    33%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  891    435    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                           Stmts   Miss  Cover
	 --------------------------------------------------
	 source_onesignal/__init__.py       2      0   100%
	 source_onesignal/source.py        25      2    92%
	 source_onesignal/streams.py      107      6    94%
	 --------------------------------------------------
	 TOTAL                            134      8    94%

@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 4, 2021 01:36 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 4, 2021 01:38 Inactive
alafanechere
alafanechere approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we've an insight about why this complex logic was implemented?

@marcosmarxm
Copy link
Member Author

marcosmarxm commented Nov 9, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-onesignal

🕑 connectors/source-onesignal https://github.com/airbytehq/airbyte/actions/runs/1440560289
❌ connectors/source-onesignal https://github.com/airbytehq/airbyte/actions/runs/1440560289

@marcosmarxm
Copy link
Member Author

Do we've an insight about why this complex logic was implemented?

I think the user was trying to enhance the types, which makes sense, but it's better keep simple.

@jrhizor jrhizor temporarily deployed to more-secrets November 9, 2021 17:12 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Nov 10, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-onesignal

🕑 connectors/source-onesignal https://github.com/airbytehq/airbyte/actions/runs/1446485392
❌ connectors/source-onesignal https://github.com/airbytehq/airbyte/actions/runs/1446485392

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 10, 2021
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 10, 2021 23:01 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Nov 10, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-onesignal

🕑 connectors/source-onesignal https://github.com/airbytehq/airbyte/actions/runs/1446597125
✅ connectors/source-onesignal https://github.com/airbytehq/airbyte/actions/runs/1446597125

@jrhizor jrhizor temporarily deployed to more-secrets November 10, 2021 23:37 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 11, 2021 00:11 Inactive
@marcosmarxm marcosmarxm merged commit 760f429 into master Nov 11, 2021
@marcosmarxm marcosmarxm deleted the marcos/correct-onesignal-get-updt-state branch November 11, 2021 00:28
@jrhizor jrhizor mentioned this pull request Nov 11, 2021
Merged
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
@marcosmarxm @schlattk
Source OneSignal: correct get_update_state and unit test (airbytehq#7617
dd01beb 
)

* correct get_update_state and unit test

* bunmp version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alafanechere alafanechere alafanechere approved these changes

@harshithmullapudi harshithmullapudi Awaiting requested review from harshithmullapudi

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source OneSignal: failed to use incremental streams
3 participants
@marcosmarxm @alafanechere @jrhizor