Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 New destination: Redis #7653

Merged
merged 15 commits into from
Nov 20, 2021
Merged

🎉 New destination: Redis #7653

merged 15 commits into from
Nov 20, 2021

Conversation

itaseskii
Copy link
Contributor

@itaseskii itaseskii commented Nov 4, 2021

What

The MR adds new destination connector for Redis https://redis.io/

How

Using Jedis https://github.com/redis/jedis

Recommended reading order

  1. x.java
  2. y.python

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 4, 2021
@itaseskii
Copy link
Contributor Author

Proof of passing acceptance tests
Screenshot_12
Screenshot_2021-11-04 Test results - RedisDestinationAcceptanceTest

@marcosmarxm marcosmarxm self-assigned this Nov 8, 2021
@marcosmarxm
Copy link
Member

Hello @itaseskii ! Sorry to not finished your contribution before the date stipulated in the contest. All contributions made before 15-November are eligible to receive the award. We're trying to review your contribution as soon as possible.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome @itaseskii

@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 20, 2021 02:10 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 20, 2021 02:12 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 20, 2021 11:06 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets November 20, 2021 13:58 Inactive
@marcosmarxm marcosmarxm merged commit 8a957ca into airbytehq:master Nov 20, 2021
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* add redis destination connector

* add redis destination connector

* refactor & docs

* format

* refactor code

* debug checkpoint

* refactor and code cleanup

* format code

* add redis docs

* bump version, docs and run seed:

* correct uuid

Co-authored-by: Marcos Marx <[email protected]>
@misteryeo
Copy link
Contributor

Issue was linked to Harvestr Discovery: New Destination: Redis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants