Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom auto-setup temporal docker image #7681

Merged
merged 71 commits into from
Nov 10, 2021

Conversation

benmoriceau
Copy link
Contributor

What

Make the update of temporal possible.

How

This is a custom auto-setup script for the temporal environment. Unfortunately there is no other way properly update the DB without copy pasting parts of the temporal auto-setup script. Ideally temporal would provide a dedicated container for it DB but it is not the case right now.

@benmoriceau benmoriceau marked this pull request as ready for review November 10, 2021 18:18
@benmoriceau benmoriceau temporarily deployed to more-secrets November 10, 2021 18:20 Inactive
@benmoriceau
Copy link
Contributor Author

Added some comments.

My main worry is around upgrading to a new Temporal version after this. Do we need to update the update script itself to be able to do that? Is there a way to detect incompatibilities via automated testing?

I added a test, It is hacky and based on the fact that the docker compose up takes less than 1 minute.

@benmoriceau benmoriceau temporarily deployed to more-secrets November 10, 2021 19:24 Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets November 10, 2021 22:11 Inactive
@benmoriceau benmoriceau temporarily deployed to more-secrets November 10, 2021 22:14 Inactive
@benmoriceau benmoriceau merged commit e20d98f into master Nov 10, 2021
@benmoriceau benmoriceau deleted the bmoric/temporal-possible-migration branch November 10, 2021 22:32
benmoriceau added a commit that referenced this pull request Nov 10, 2021
benmoriceau added a commit that referenced this pull request Nov 10, 2021
benmoriceau added a commit that referenced this pull request Nov 10, 2021
benmoriceau added a commit that referenced this pull request Nov 10, 2021
cgardens pushed a commit that referenced this pull request Nov 11, 2021
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
This is a custom auto-setup script for the temporal environment. Unfortunately there is no other way properly update the DB without copy pasting parts of the temporal auto-setup script. Ideally temporal would provide a dedicated container for it DB but it is not the case right now.
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants