Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Salesforce: Handling 400 error when using BULK API #8206

Merged

Conversation

yevhenii-ldv
Copy link
Contributor

What

resolves #7518.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? If yes, please make sure to include it here and in any changelogs with the 🚨🚨 emoji
What is the end result perceived by the user?

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Nov 23, 2021

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1495133137
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1495133137
🐛 https://gradle.com/s/berx7vupbnvmu

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 23, 2021
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets November 23, 2021 14:13 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 23, 2021 14:14 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Nov 23, 2021

/test connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1495485154
❌ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1495485154
🐛 https://gradle.com/s/y3s2aleg7fmsu

@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets November 23, 2021 15:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets November 23, 2021 15:38 Inactive
@yevhenii-ldv
Copy link
Contributor Author

yevhenii-ldv commented Nov 24, 2021

/publish connector=connectors/source-salesforce

🕑 connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1499475288
✅ connectors/source-salesforce https://github.com/airbytehq/airbyte/actions/runs/1499475288

@jrhizor jrhizor temporarily deployed to more-secrets November 24, 2021 13:10 Inactive
@yevhenii-ldv yevhenii-ldv merged commit 81d66a6 into master Nov 24, 2021
@yevhenii-ldv yevhenii-ldv deleted the ykurochkin/handling-400-error-using-bulk-api-for-sync branch November 24, 2021 13:42
@yevhenii-ldv yevhenii-ldv temporarily deployed to more-secrets November 24, 2021 13:43 Inactive
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
…8206)

* Source Salesforce: Handling 400 error when using BULK API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Salesforce source: 400 bad request error fails connector
5 participants