Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Stripe: Rearrange setup fields #8250

Merged
merged 5 commits into from
Nov 26, 2021

Conversation

bazarnov
Copy link
Collaborator

What

#7852

How

  • edited spec.json

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@bazarnov bazarnov self-assigned this Nov 25, 2021
@bazarnov bazarnov linked an issue Nov 25, 2021 that may be closed by this pull request
@github-actions github-actions bot added the area/connectors Connector related issues label Nov 25, 2021
@bazarnov
Copy link
Collaborator Author

bazarnov commented Nov 25, 2021

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1503544395
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1503544395
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_stripe/__init__.py       2      2     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-stripe/.venv/lib/python3.8/site-packages/coverage/control.py:761: CoverageWarning: No data was collected. (no-data-collected)
	 source_stripe/source.py        22     22     0%
	 source_stripe/streams.py      195    195     0%
	 -----------------------------------------------
	 TOTAL                         219    219     0%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_stripe/__init__.py       2      0   100%
	 source_stripe/source.py        22     11    50%
	 source_stripe/streams.py      195     80    59%
	 -----------------------------------------------
	 TOTAL                         219     91    58%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        75      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       38     27    29%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 62     25    60%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  896    440    51%

@jrhizor jrhizor temporarily deployed to more-secrets November 25, 2021 11:49 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Nov 25, 2021
@bazarnov bazarnov temporarily deployed to more-secrets November 25, 2021 11:51 Inactive
@bazarnov
Copy link
Collaborator Author

bazarnov commented Nov 26, 2021

/publish connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1507620953
✅ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/1507620953

@jrhizor jrhizor temporarily deployed to more-secrets November 26, 2021 13:02 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets November 26, 2021 13:18 Inactive
@bazarnov bazarnov temporarily deployed to more-secrets November 26, 2021 13:51 Inactive
@bazarnov bazarnov merged commit a4a5cb8 into master Nov 26, 2021
@bazarnov bazarnov deleted the bazarnov/7852-stripe-order-of-fields branch November 26, 2021 14:06
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rearrange Stripe setup fields
3 participants