-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Bigcommerce: dates comparison in incremental #8416
Merged
marcosmarxm
merged 7 commits into
airbytehq:master
from
jacqueskpoty:fix_RFC2822_dates_comparison_source_bigcommerce
Dec 8, 2021
Merged
Source Bigcommerce: dates comparison in incremental #8416
marcosmarxm
merged 7 commits into
airbytehq:master
from
jacqueskpoty:fix_RFC2822_dates_comparison_source_bigcommerce
Dec 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/documentation
Improvements or additions to documentation
area/frontend
area/platform
issues related to the platform
area/scheduler
area/server
area/worker
Related to worker
CDK
Connector Development Kit
kubernetes
labels
Dec 8, 2021
marcosmarxm
force-pushed
the
fix_RFC2822_dates_comparison_source_bigcommerce
branch
2 times, most recently
from
December 8, 2021 02:56
02e77c0
to
df281ba
Compare
github-actions
bot
removed
area/frontend
CDK
Connector Development Kit
area/platform
issues related to the platform
area/worker
Related to worker
area/server
area/documentation
Improvements or additions to documentation
kubernetes
area/scheduler
labels
Dec 8, 2021
marcosmarxm
force-pushed
the
fix_RFC2822_dates_comparison_source_bigcommerce
branch
from
December 8, 2021 03:15
df281ba
to
83c0912
Compare
github-actions
bot
added
the
area/documentation
Improvements or additions to documentation
label
Dec 8, 2021
marcosmarxm
approved these changes
Dec 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @jacqueskpoty
Published connector in #8610 |
marcosmarxm
changed the title
Fix rfc2822 dates comparison source bigcommerce
Source Bigcommerce: dates comparison in incremental
Dec 8, 2021
schlattk
pushed a commit
to schlattk/airbyte
that referenced
this pull request
Jan 4, 2022
* fix RFC2822 dates comparison * quick fix * merged into master * quick fix * run format * bump version * run seed file Co-authored-by: jsewawilson <[email protected]> Co-authored-by: Marcos Marx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
community
connectors/source/bigcommerce
connectors/sources-database
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
BigCommerce uses RFC 2822 as date format for some date fields such as date_created, date_modified which are used as cursors in incremental data pulls. Failing to convert this date format into the ISO format results in incremental pulls not working efficiently due to inaccuracies of cursor state.
How
This Pull request makes sure the RFC 2822 date fields when used as cursors, are converted to the right format in order to keep cursors state accurate.
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? If yes, please make sure to include it here and in any changelogs with the 🚨🚨 emoji
What is the end result perceived by the user?
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/SUMMARY.md
docs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing./publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changes