Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Bigcommerce: dates comparison in incremental #8416

Conversation

jacqueskpoty
Copy link
Contributor

What

BigCommerce uses RFC 2822 as date format for some date fields such as date_created, date_modified which are used as cursors in incremental data pulls. Failing to convert this date format into the ISO format results in incremental pulls not working efficiently due to inaccuracies of cursor state.

How

This Pull request makes sure the RFC 2822 date fields when used as cursors, are converted to the right format in order to keep cursors state accurate.

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? If yes, please make sure to include it here and in any changelogs with the 🚨🚨 emoji
What is the end result perceived by the user?

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Dec 2, 2021
@marcosmarxm marcosmarxm temporarily deployed to more-secrets December 8, 2021 02:53 Inactive
@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/frontend area/platform issues related to the platform area/scheduler area/server area/worker Related to worker CDK Connector Development Kit kubernetes labels Dec 8, 2021
@marcosmarxm marcosmarxm force-pushed the fix_RFC2822_dates_comparison_source_bigcommerce branch 2 times, most recently from 02e77c0 to df281ba Compare December 8, 2021 02:56
@github-actions github-actions bot removed area/frontend CDK Connector Development Kit area/platform issues related to the platform area/worker Related to worker area/server area/documentation Improvements or additions to documentation kubernetes area/scheduler labels Dec 8, 2021
@marcosmarxm marcosmarxm force-pushed the fix_RFC2822_dates_comparison_source_bigcommerce branch from df281ba to 83c0912 Compare December 8, 2021 03:15
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 8, 2021
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jacqueskpoty

@marcosmarxm
Copy link
Member

Published connector in #8610

@marcosmarxm marcosmarxm merged commit c496368 into airbytehq:master Dec 8, 2021
@marcosmarxm marcosmarxm changed the title Fix rfc2822 dates comparison source bigcommerce Source Bigcommerce: dates comparison in incremental Dec 8, 2021
schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022
* fix RFC2822 dates comparison

* quick fix

* merged into master

* quick fix

* run format

* bump version

* run seed file

Co-authored-by: jsewawilson <[email protected]>
Co-authored-by: Marcos Marx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants